-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: redistributed the @fuel-ts/interfaces
package
#3492
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodSpeed Performance ReportMerging #3492 will degrade performances by 20.19%Comparing Summary
Benchmarks breakdown
|
@fuel-ts/interfaces
package@fuel-ts/interfaces
package
"@fuel-ts/utils": patch | ||
--- | ||
|
||
chore!: redistributed the `@fuel-ts/interfaces` package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nedsalk @Torres-ssf Do you remember why we couldn't do this in the past? I think it was some cyclic dependencies or something, and I wonder if we're missing something here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that there were some cyclic dependencies with regards to accounts and providers but they might have been resolved with the merger of those packages into the single @fuel-ts/account
package. I feel like the removal of AbstractProgram
should've also caused some issues, but perhaps we have refactored out the logic which depended on its existence.
All in all, if the CI is green then IMO we can proceed reviewing and ultimately merging it.
Coverage Report:
Changed Files:
|
Release notes
In this release, we:
AbstractAddress
in favour of theAddress
class.Summary
@fuel-ts/interfaces
to their associated packages.AbstractAddress
in favour of theAddress
class to ensure synced functionality.Breaking Changes
AbstractAddress
class; use theAddress
class instead.@fuel-ts/interfaces
package; use thefuels
package instead.Checklist