Extend triple target to everything distributed by forc #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfiedotwtf
force-pushed
the
alfie/triple-double
branch
from
2ba1c68
to
24064ac
Compare
alfiedotwtf
changed the title
alfiedotwtf
force-pushed
the
alfie/triple-double
branch
2 times, most recently
from
62341f0
to
feb64b0
Compare
JoshuaBatty
reviewed
Oct 28, 2024
src/target_triple.rs
Outdated
| @@ -53,40 +53,37 @@ impl TargetTriple { | |||
| } | |||
|
|
|||
| pub fn from_component(component: &str) -> Result<Self> { | |||
There was a problem hiding this comment.
can we add a doc comment. feel free to tweak the below
/// Creates a target triple for the given component.
///
/// For components distributed by forc, uses the format "{os}_{architecture}".
/// For other components, uses the format "{architecture}-{vendor}-{os}".
feb64b0
to
5bda149
Compare
1. forc-binaries, which is of the format "{os}_{arch}"
2. Everything else, which is the standard "{arch}-{vendor}-{os}"
Currently, we only use the "{os}_{arch}" URL if the component is forc,
however the forc-binaries tarball contains plugins and executables not
defined in the forc component.
This PR extends the "{os}_{arch}" result to everything distributed from
forc.
alfiedotwtf
force-pushed
the
alfie/triple-double
branch
from
5bda149
to
274463d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is rebased on top of #666 👹
There are 2 types of downloads:
Currently, we only use the "{os}_{arch}" URL if the component is
forc, however theforc-binariestarball contains plugins and executables not defined in theforccomponent.This PR extends the "{os}_{arch}" result to everything distributed from
forc.This fixes an issue found while investigating #654.