Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4318 forc-crypto plugin exposing a CLI for common-use cryptographic operations #5153

Merged
merged 22 commits into from
Oct 28, 2023
Merged

#4318 forc-crypto plugin exposing a CLI for common-use cryptographic operations #5153

merged 22 commits into from
Oct 28, 2023

Conversation

cr-fuel
Copy link
Contributor

@cr-fuel cr-fuel commented Sep 28, 2023 •
edited
Loading

Description

Fixes #4318

Supported algorithms:

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@cr-fuel cr-fuel force-pushed the cr/forc-crypto-plugin branch 11 times, most recently from c51eb87 to 95c364d Compare September 30, 2023 17:19
@cr-fuel cr-fuel marked this pull request as ready for review September 30, 2023 19:01
@cr-fuel cr-fuel changed the title WIP: #4318 forc-crypto plugin exposing a CLI for common-use cryptographic operations #4318 forc-crypto plugin exposing a CLI for common-use cryptographic operations Sep 30, 2023
@cr-fuel cr-fuel requested review from sdankel, Voxelot, JoshuaBatty and a team September 30, 2023 19:01
@cr-fuel cr-fuel enabled auto-merge (squash) September 30, 2023 19:02
@JoshuaBatty JoshuaBatty added enhancement New feature or request forc labels Oct 1, 2023
JoshuaBatty
JoshuaBatty requested changes Oct 1, 2023
View reviewed changes
Copy link
Member

@JoshuaBatty JoshuaBatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind also adding a video of it being used to the description. thanks.

forc-plugins/forc-crypto/Cargo.toml Outdated Show resolved Hide resolved
forc-plugins/forc-crypto/Cargo.toml Outdated Show resolved Hide resolved
forc-plugins/forc-crypto/src/address.rs Outdated Show resolved Hide resolved
forc-plugins/forc-crypto/src/content.rs Outdated Show resolved Hide resolved
forc-plugins/forc-crypto/src/content.rs Outdated Show resolved Hide resolved
forc-plugins/forc-crypto/src/maybe_file.rs Outdated Show resolved Hide resolved
forc-plugins/forc-crypto/src/maybe_file.rs Outdated Show resolved Hide resolved
forc-plugins/forc-crypto/src/maybe_file.rs Outdated Show resolved Hide resolved
forc-plugins/forc-crypto/src/maybe_file.rs Outdated Show resolved Hide resolved
forc-plugins/forc-crypto/src/maybe_file.rs Outdated Show resolved Hide resolved
@JoshuaBatty JoshuaBatty requested a review from a team October 1, 2023 23:23
kayagokalp
kayagokalp requested changes Oct 2, 2023
View reviewed changes
forc-plugins/forc-crypto/Cargo.toml Outdated Show resolved Hide resolved
forc-plugins/forc-crypto/src/main.rs Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
forc-plugins/forc-crypto/src/content.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@JoshuaBatty JoshuaBatty requested a review from a team October 2, 2023 01:31
kayagokalp
kayagokalp reviewed Oct 2, 2023
View reviewed changes
forc-plugins/forc-crypto/src/main.rs Outdated Show resolved Hide resolved
forc-plugins/forc-crypto/src/address.rs Outdated Show resolved Hide resolved
@kayagokalp kayagokalp requested a review from a team October 2, 2023 01:51
@cr-fuel
Copy link
Contributor Author

cr-fuel commented Oct 2, 2023

Screen.Recording.2023-10-02.at.02.02.40.mov

cr-fuel and others added 17 commits October 27, 2023 22:13
@cr-fuel
Fixed clippy issues
981dcb3
@cr-fuel
Move args related code to their own file
a5b7752 
Added unit tests to the argument parsing logic
@cr-fuel
Fixed clippy issue
0ea2170
@cr-fuel
Port f0fd46d795b795ab9cec474d52db32725b499277 from FuelLabs/fuel-core…
7951ae4 
…#1426
@cr-fuel
Print secret message to tty, normal message otherwise
3756de5 
Port 586ff3e547feddb782dde3d8dde7e45842df92ba from FuelLabs/fuel-core#1426

Context: FuelLabs/fuel-core#1426 (comment)
@cr-fuel @JoshuaBatty
Update forc-plugins/forc-crypto/Cargo.toml
84a0f65 
Co-authored-by: Joshua Batty <joshpbatty@gmail.com>
@cr-fuel @JoshuaBatty
Update forc-plugins/forc-crypto/Cargo.toml
035c2ee 
Co-authored-by: Joshua Batty <joshpbatty@gmail.com>
@cr-fuel @JoshuaBatty
Update forc-plugins/forc-crypto/Cargo.toml
599d6b0 
Co-authored-by: Joshua Batty <joshpbatty@gmail.com>
@cr-fuel
Accept empty "" argument without attempting to read the stdin
b154b73
@cr-fuel
More changes requested by code review
3a8da24
@cr-fuel @sdankel
Update forc-plugins/forc-crypto/src/keygen/new_key.rs
034c4c0 
Co-authored-by: Sophie Dankel <47993817+sdankel@users.noreply.github.com>
@cr-fuel
Have a better way to print to stdout
57ecabc 
Each handler will return a serde_json::Value instead of printing
themselves
@cr-fuel
Clippy and more code improvements
1a5ae28
@cr-fuel
Add doc-comments
a7eca67
@cr-fuel
Cargo fmt
c79d7da
@cr-fuel
Update test
1583fe5
@cr-fuel
Addressed suggestions
d22eab0
kayagokalp
kayagokalp approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice 👌 Haven't tested the latest version locally but changes from the last review looks good to me! utACK

forc-plugins/forc-crypto/src/keygen/new_key.rs Show resolved Hide resolved
sdankel
sdankel approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@sdankel sdankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cr-fuel cr-fuel merged commit 6d345f6 into master Oct 28, 2023
32 checks passed
@cr-fuel cr-fuel deleted the cr/forc-crypto-plugin branch October 28, 2023 14:54
cr-fuel added a commit to FuelLabs/fuel-core that referenced this pull request Oct 31, 2023
@cr-fuel
Improvements for keygen cli and crates
a065b3f 
Import improvements from FuelLabs/sway#5153.

Once this PR is merged and a new release is created sway will reference
this crate instead of having its own copy.
cr-fuel added a commit to FuelLabs/fuel-core that referenced this pull request Oct 31, 2023
@cr-fuel
Improvements for keygen cli and crates
c55bd1f 
Import improvements from FuelLabs/sway#5153.

Once this PR is merged and a new release is created sway will reference
this crate instead of having its own copy.
cr-fuel added a commit to FuelLabs/fuel-core that referenced this pull request Oct 31, 2023
@cr-fuel
Improvements for keygen cli and crates
1662f15 
Import improvements from FuelLabs/sway#5153.

Once this PR is merged and a new release is created sway will reference
this crate instead of having its own copy.
@cr-fuel cr-fuel mentioned this pull request Oct 31, 2023
Merged
cr-fuel added a commit to FuelLabs/fuel-core that referenced this pull request Oct 31, 2023
@cr-fuel
Improvements for keygen cli and crates
62e9c76 
Import improvements from FuelLabs/sway#5153.

Once this PR is merged and a new release is created sway will reference
this crate instead of having its own copy.
cr-fuel added a commit to FuelLabs/fuel-core that referenced this pull request Oct 31, 2023
@cr-fuel
Improvements for keygen cli and crates
5686e72 
Import improvements from FuelLabs/sway#5153.

Once this PR is merged and a new release is created sway will reference
this crate instead of having its own copy.
cr-fuel added a commit to FuelLabs/fuel-core that referenced this pull request Nov 1, 2023
@cr-fuel
Improvements for keygen cli and crates (#1465)
8a323ad 
Import improvements from FuelLabs/sway#5153.

Once this PR is merged and a new release is created sway will reference
this crate instead of having its own copy
(FuelLabs/sway#5170)
crypto523 added a commit to crypto523/fuel-core that referenced this pull request Oct 7, 2024
@crypto523
Improvements for keygen cli and crates (#1465)
691a7ea 
Import improvements from FuelLabs/sway#5153.

Once this PR is merged and a new release is created sway will reference
this crate instead of having its own copy
(FuelLabs/sway#5170)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdankel sdankel sdankel approved these changes

@kayagokalp kayagokalp kayagokalp approved these changes

@Voxelot Voxelot Awaiting requested review from Voxelot

@JoshuaBatty JoshuaBatty Awaiting requested review from JoshuaBatty

Assignees

@cr-fuel cr-fuel

Labels
enhancement New feature or request forc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a forc-crypto plugin exposing a CLI for common-use cryptographic operations
4 participants
@cr-fuel @JoshuaBatty @kayagokalp @sdankel