Add black in pre-commit and also formatted exiting code as per black #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tucosaurus
approved these changes
Sep 25, 2019
|
I thought about migration files as well. My thought on it: "Those files get edited by devs and it's okay to format them for readability, machines doesn't care of about formatting anyways". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep the code styling standard for every developer.
Using black to format code, black is added to pre-commit so the code is always formatted before making a commit.
There could be cases that a dev doesn't want a restrictive formatting. I think having a tool to format the code for everyone wins. Readability and code-reviews matter.