Bug Report: Setting custom notesprite looping to true in the notestyles JSON file only loops the animation until a note is pressed

[DaWaterMalone]

Issue Checklist

• I have properly named my issue
• I have checked the Issues/Discussions pages to see if my issue has already been reported

Platform

Compiled from GitHub Source Code

Browser

None

Version

0.5.1

Description (include any images, videos, errors, or crash logs)

I have been trying to add new strumlineNote sprites to the game for a mod I am porting over using the new NoteStyle JSON files. When I add the new note sprite data to the noteStrumline portion of the NoteStyle JSON file and set "looped" : true for each of the static note properties, in-game, the strumlineNote sprites start looping their animations until a chart note has been pressed, then the looping animation stops.

Digging through the source code, I have found the cause of this issue. Inside the StrumlineNote.hx file, somebody set this.active = false; within the playStatic() function on line 106. By setting this.active = true; it fixes the strumlineNote sprites animation and allows the sprites to keep looping even after notes have been pressed on the screen.

Broken StrumlineNote Animations when playStatic() this.active = false;

Broken.Animations.mp4

Working StrumlineNote Animations when setting playStatic() this.active = true;

Working.Animations.mp4

Custom NoteStyle JSON file for reference:

Function inside of StrumlineNote.hx that is causing the issue:

Steps to Reproduce

1. Create a custom NoteStyle JSON file
2. Put the JSON file in the new NoteStyle folder
3. Launch the game
4. Enter into a stage that uses the new custom NoteStyle JSON file
5. Start hitting Strumline notes