Fixed Conflict With Modded StrumlineNote Sprite Looping Animation #3577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within the playStatic function on the StrumlineNote.hx, setting this.active = true; will fix looping animations for modded in StrumlineNote sprites. Leaving this.active = false; will stop any modded StrumlineNote sprite animation when the player or opponent hits chart notes.
github-actions
bot
added
the
medium
EliteMasterEric
added
type: enhancement
|
Merged after making a few tweaks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
#3571
Briefly describe the issue(s) fixed.
The playStatic function on the StrumlineNote.hx file has this.active = false; which breaks modding compatibility for StrumlineNote sprites with looping animations. By setting this.active = true; it allows StrumlineNote sprites to loop an animation that is defined in the new notestyles folder.
Include any relevant screenshots or videos.
Broken StrumlineNote Animations when playStatic() this.active = false;
Broken.Animations.mp4
Working StrumlineNote Animations when setting playStatic() this.active = true;
Working.Animations.mp4
Custom NoteStyle JSON file for reference:
