Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed stutter once a wipe transition to the Main Menu completes. #2315

Merged
merged 1 commit into from
May 9, 2024
Merged

Fixed stutter once a wipe transition to the Main Menu completes. #2315

merged 1 commit into from
May 9, 2024

Conversation

ImCodist
Copy link
Contributor

@ImCodist ImCodist commented May 8, 2024

There is this bit of code in the MainMenuState that I assume was supposed to run immediately after changing to the state but instead is run after the transition completes to the state.
This causes the camera to be reset when the transition completes, creating a stutter effect.

I've tested this from multiple scenarios where the state is changed to MainMenuState and nothing seems to break.

i am not sure why this bit of code exists in the first place actually since the camera reset call made just before it seems to work just fine but idk

Footage of this problem happening in game (i apologize for the overlapping music i am too tired to rerecord this clip):

Funkin_JsBtvCm3OO.mp4

@ninjamuffin99
Copy link
Member

haha wow nice catch! that bugged me for the longest time lol....

@ninjamuffin99 ninjamuffin99 merged commit 4bd8542 into FunkinCrew:develop May 9, 2024
@ninjamuffin99 ninjamuffin99 added this to the 0.3.3 milestone May 9, 2024
@ImCodist ImCodist deleted the bugfix/main-menu-camera-stutter branch May 15, 2024 02:57
@amyspark-ng amyspark-ng mentioned this pull request May 20, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants