Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart debug key takes you back to chart editor if you're charting #2323

Merged
merged 2 commits into from
May 9, 2024

Conversation

nebulazorua
Copy link
Contributor

Multiple times I've pressed the chart key while already chart play-testing and lost my chart
This makes it just take you back to the chart editor if you press it while testing

@Raltyro
Copy link

Raltyro commented May 8, 2024

fire pull request

@nebulazorua
Copy link
Contributor Author

gonna move this into a new branch hold on

@nebulazorua nebulazorua closed this May 8, 2024
@nebulazorua
Copy link
Contributor Author

ehh nvm im fucking LAZY

@nebulazorua nebulazorua reopened this May 8, 2024
@nebulazorua nebulazorua changed the base branch from main to develop May 8, 2024 20:57
@EliteMasterEric EliteMasterEric self-requested a review May 9, 2024 03:14
Copy link
Member

@EliteMasterEric EliteMasterEric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was really slick and felt good to use! Tested live on stream.

@EliteMasterEric EliteMasterEric merged commit 34a6e16 into FunkinCrew:develop May 9, 2024
@EliteMasterEric EliteMasterEric added this to the 0.4.0 milestone Jul 12, 2024
@Hundrec
Copy link
Contributor

Hundrec commented Oct 13, 2024

Changelog Review Note: This belongs in the 0.3.3 milestone

Thanks for this change!

@EliteMasterEric EliteMasterEric modified the milestones: 0.4.0, 0.3.3 Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants