Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish for the transition from GameOverSubState back into PlayState. #2390

Merged
merged 1 commit into from
May 15, 2024
Merged

Polish for the transition from GameOverSubState back into PlayState. #2390

merged 1 commit into from
May 15, 2024

Conversation

ImCodist
Copy link
Contributor

@ImCodist ImCodist commented May 9, 2024

When retrying from the GameOverSubState the current implementation has some issues due to being a sub state now.
This PR attempts to fix those issues.

Things that are altered:

  • The "vwoosh" transition is removed from game overs.
  • Notes are cleaned before entering the sub state, fixing a flicker effect while the black fade out is playing.
  • The health bar (and its icons) no longer lerp back to the default value upon returning to PlayState.
  • The score is no longer retained for one frame.

The way this is done is admittedly a little hacky, but is (what i believe to be) the best way around it without making any major alterations to the code. (Scary)

I am unsure if the vwoosh transition and the health bar lerp is intended when retrying a song through the GameOverSubState. So those changes are subjective.
Completely understand if this isn't merged due to my lack of information on that regard.

Heres a before and after video:

itsthelittlethings.mp4

@Raltyro
Copy link

Raltyro commented May 9, 2024

hi codist

@ninjamuffin99 ninjamuffin99 added this to the 0.3.3 milestone May 15, 2024
@ninjamuffin99 ninjamuffin99 merged commit 5e70d9f into FunkinCrew:develop May 15, 2024
@ImCodist ImCodist deleted the polish/game-over-transition branch May 15, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants