Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Pause Menu and Stickers have same zoom as HUD #2567

Merged

Conversation

gamerbross
Copy link
Contributor

@gamerbross gamerbross commented May 20, 2024

(FunkinCrew/funkin.assets#7 required!!!)
The Pause Menu and Stickers Transition were using camHUD, which its zoom can change, scaling these without having to.
I added camOther as another camera which contains video cutscenes, dialogues, pause menu and sticker transition (or whatever that shouldn't have the same zoom as HUD)
I also removed camCutscene, because can be replaced with this new one.

Here I'm going to attach some issues caused by unintentional zoom.
(M.I.L.F. is a great song to use, as it zooms the HUD more)

image
Pause Menu getting cut by the HUD zoom.

Recording.2024-05-20.031208.mp4

Sticker Transition zooming out a little bit

@Matriculaso
Copy link

Matriculaso commented May 20, 2024

Pretty Useful tbh, I had an issue with stickers cuz I used a lot of camZoomings events and stickers were pretty messed up along with pause menu, Thanks gamerbross!

@gamerbross gamerbross marked this pull request as draft May 20, 2024 21:05
@gamerbross
Copy link
Contributor Author

Ok it has some issues that I didn't saw because when I was trying it, camCutscene still existed, so there were no problems

@gamerbross
Copy link
Contributor Author

Just fixed those issues (now needs this pr in funkin.assets FunkinCrew/funkin.assets#7)
(it also fixed one bug in the roses end cutscene!!!)
image
Pause menu was on camHUD, so this red camera flash on camCutscene covered it, putting everything red.

@Matriculaso
Copy link

hurry up and add this shit my grilfriend feet sticker pack needs this!!! feet is too big because of the zoom I do on her feet helpp pleass 😫😫😫😫

@Stilic
Copy link

Stilic commented May 30, 2024

the renaming isn't needed.
it could cause breaking with existing scripts.

source/funkin/play/PlayState.hx Outdated Show resolved Hide resolved
@gamerbross
Copy link
Contributor Author

I reverted the camCutscene rename, so now the pull request in assets isn't really required, just removes unnecessary visibility changes to the camera

@Matriculaso
Copy link

image

@EliteMasterEric EliteMasterEric added status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue. status: reviewing internally This PR is under internal review and quality assurance testing and removed status: pending triage The bug or PR has not been reviewed yet. labels Jun 17, 2024
@EliteMasterEric EliteMasterEric self-assigned this Jul 10, 2024
@EliteMasterEric EliteMasterEric added the small A small pull request with 10 or fewer changes label Jul 10, 2024
@EliteMasterEric EliteMasterEric deleted the branch FunkinCrew:develop July 12, 2024 00:59
Copy link
Member

@EliteMasterEric EliteMasterEric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good for me

@EliteMasterEric EliteMasterEric added status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally This PR is under internal review and quality assurance testing labels Jul 12, 2024
@EliteMasterEric EliteMasterEric added this to the 0.5.0 milestone Jul 12, 2024
@gamerbross gamerbross changed the title [BUGFIX] Pause Menu and Stickers have same zoom as HUD (+ camOther) [BUGFIX] Pause Menu and Stickers have same zoom as HUD Jul 13, 2024
@EliteMasterEric EliteMasterEric merged commit 82c2d54 into FunkinCrew:develop Sep 16, 2024
@gamerbross gamerbross deleted the bugfix/pause-sticker-zoom branch September 25, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small A small pull request with 10 or fewer changes status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants