[BUGFIX] Song with no "Normal" causes Stack Overflow #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please merge pweese 🙏 |
tposejank
approved these changes
Jun 9, 2024
|
omg thank you for catching this, I vouch for this fix! |
8 tasks
trayfellow
approved these changes
Jun 15, 2024
EliteMasterEric
added
status: pending triage
|
Testing the "before" on this is hilarious because I attempted to open Freeplay and the game immediately closed with no fanfare lol. |
EliteMasterEric
added
status: accepted
AppleHair
added a commit
to AppleHair/FunkinApple
that referenced
this pull request
Jul 17, 2024
charlesisfeline
pushed a commit
to VsFoxaTeam/Funkin
that referenced
this pull request
Jul 23, 2024
Closed
2 tasks
ninjamuffin99
pushed a commit
that referenced
this pull request
Sep 16, 2024
|
Let's gooo 😭😭
…On Mon, Sep 16, 2024, 6:34 p.m. Eric ***@***.***> wrote:
Merged #2712 <#2712> into
develop.
—
Reply to this email directly, view it on GitHub
<#2712 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATNYONJDOR7FAWMXDI6FVOLZW5MHHAVCNFSM6AAAAABJAKM5OGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGI4DCOJSGEZTAMI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check was removed in 4311dd2 to fix "dadbattle" but doesn't seem to be related and now causes a stack overflow, and crash, if a song doesn't have "Normal" difficulty
Closes #2693