Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fixed cancelMenu sound not playing after switching state #2986

Merged

Conversation

AppleHair
Copy link
Contributor

So in StoryMenuState and OptionsState, the cancelMenu sound doesn't play when coming back to MainMenuState, and in MainMenuState, the cancelMenu sound doesn't play when coming back to TitleState. This happens because MusicBeatState's startOutro runs FunkinSound.stopAllAudio, which means every sound played before the call to FlxG.switchState, which calls startOutro, will be stopped. To fix this, instead of calling FunkinSound.playOnce BEFORE FlxG.switchState, we call it AFTER FlxG.switchState. Easy!

@EliteMasterEric EliteMasterEric added status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue. status: reviewing internally This PR is under internal review and quality assurance testing small A small pull request with 10 or fewer changes and removed status: pending triage The bug or PR has not been reviewed yet. labels Jul 10, 2024
@EliteMasterEric EliteMasterEric self-assigned this Jul 10, 2024
@EliteMasterEric EliteMasterEric added status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally This PR is under internal review and quality assurance testing labels Jul 10, 2024
@EliteMasterEric
Copy link
Member

👍

@EliteMasterEric EliteMasterEric deleted the branch FunkinCrew:develop July 12, 2024 01:00
@EliteMasterEric EliteMasterEric added this to the 0.5.0 milestone Jul 12, 2024
@EliteMasterEric EliteMasterEric merged commit 8c6cb72 into FunkinCrew:develop Sep 16, 2024
@AppleHair AppleHair deleted the bugfix/cancel-menu-sound branch September 27, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small A small pull request with 10 or fewer changes status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants