Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] F5 now reloads the chart in the PlayState #2990

Merged
merged 2 commits into from
Sep 16, 2024
Merged

[BUGFIX] F5 now reloads the chart in the PlayState #2990

merged 2 commits into from
Sep 16, 2024

Conversation

gamerbross
Copy link
Contributor

so cool

@EliteMasterEric EliteMasterEric added the status: pending triage The bug or PR has not been reviewed yet. label Jul 10, 2024
EliteMasterEric
EliteMasterEric requested changes Jul 10, 2024
View reviewed changes
source/funkin/play/PlayState.hx Outdated Show resolved Hide resolved
source/funkin/play/PlayState.hx Outdated Show resolved Hide resolved
@EliteMasterEric
Copy link
Member

Had one comment and I haven't reviewed this locally yet, but otherwise seems like a great PR.

Common gamerbross W.

@EliteMasterEric EliteMasterEric added type: enhancement Provides an enhancement or new feature. status: needs revision Cannot be approved because it is awaiting some work by the contributor. medium A medium pull request with 100 or fewer changes and removed status: pending triage The bug or PR has not been reviewed yet. labels Jul 10, 2024
@EliteMasterEric EliteMasterEric self-assigned this Jul 10, 2024
@EliteMasterEric EliteMasterEric changed the title [BUGFIX] F5 Key Chart not reloading [BUGFIX] F5 now reloads the chart in the PlayState Jul 11, 2024
@EliteMasterEric
Copy link
Member

Works good for me

@EliteMasterEric EliteMasterEric added status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: needs revision Cannot be approved because it is awaiting some work by the contributor. labels Jul 11, 2024
@EliteMasterEric EliteMasterEric deleted the branch FunkinCrew:develop July 12, 2024 01:00
@EliteMasterEric EliteMasterEric added this to the 0.5.0 milestone Jul 12, 2024
@EliteMasterEric EliteMasterEric merged commit c7cb03d into FunkinCrew:develop Sep 16, 2024
@gamerbross gamerbross deleted the bugfix/f5-reload-chart branch September 25, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EliteMasterEric EliteMasterEric EliteMasterEric approved these changes

Assignees

@EliteMasterEric EliteMasterEric

Labels
medium A medium pull request with 100 or fewer changes status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. type: enhancement Provides an enhancement or new feature.
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gamerbross @EliteMasterEric