Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLEANUP] Softcode Tutorial HEY! events from code to JSON #3007

Merged
merged 3 commits into from
Sep 16, 2024
Merged

[CLEANUP] Softcode Tutorial HEY! events from code to JSON #3007

merged 3 commits into from
Sep 16, 2024

Conversation

anysad
Copy link
Contributor

@anysad anysad commented Jul 11, 2024

Briefly describe the issue(s) fixed.

  • As the title suggests, moves the hardcoded HEY! events in Tutorial to already established (aka normal) events in the game. After all, why do we need danceOnBeat() called every single beat just for these 4 events?

@moxie-coder
Copy link

you need to redo your branch with the develop branch

@EliteMasterEric EliteMasterEric self-assigned this Jul 12, 2024
@EliteMasterEric EliteMasterEric added status: reviewing internally This PR is under internal review and quality assurance testing type: optimization Involves a performance issue or a bug which causes lag. medium A medium pull request with 100 or fewer changes labels Jul 12, 2024
@EliteMasterEric
Copy link
Member

The main branch had some documentation changes that develop didn't, just fixed it now.

@EliteMasterEric EliteMasterEric deleted the branch FunkinCrew:develop July 12, 2024 01:00
@EliteMasterEric EliteMasterEric added status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally This PR is under internal review and quality assurance testing labels Jul 12, 2024
@EliteMasterEric
Copy link
Member

approved

@biomseed
Copy link

biomseed commented Jul 12, 2024 •
edited
Loading

week 8 gonna be crazy with all these fixes and improvements

@EliteMasterEric EliteMasterEric added this to the 0.5.0 milestone Jul 12, 2024
@AbnormalPoof AbnormalPoof mentioned this pull request Aug 28, 2024
Closed
2 tasks
@EliteMasterEric EliteMasterEric merged commit 35b5957 into FunkinCrew:develop Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@EliteMasterEric EliteMasterEric

Labels
medium A medium pull request with 100 or fewer changes status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. type: optimization Involves a performance issue or a bug which causes lag.
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anysad @moxie-coder @EliteMasterEric @biomseed