[BUGFIX/ENHANCEMENT] Changes instances of FlxG.mouse.screen(x/y) to FlxG.mouse.view(x/y) in ChartEditorState.hx (and more) #3337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove laggy redundant traces Revert "remove laggy redundant traces" This reverts commit 2041138.
EliteMasterEric
added
type: major bug
Kade-github
changed the title
Kade-github
changed the title
charlesisfeline
approved these changes
Sep 17, 2024
AbnormalPoof
approved these changes
Sep 17, 2024
NotHyper-474
approved these changes
Sep 17, 2024
cyn0x8
approved these changes
Sep 17, 2024
tposejank
approved these changes
Sep 17, 2024
EliteMasterEric
added
status: accepted
2 tasks
rodney528
approved these changes
Sep 18, 2024
Hazardous2468
added a commit
to Hazardous2468/Funkin_Hazard-Modcharting-Fork
that referenced
this pull request
Sep 18, 2024
JVNpixels
approved these changes
Sep 18, 2024
2 tasks
|
Yay |
rodney528
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
Fixes #3147,
Briefly describe the issue(s) fixed.
Changes any instance of screenX/screenY to viewX/viewY as the former is depreciated. Causing the editor to not function due to HaxeFlixel/flixel#3210
Also adds a millisecond part of the playbar :D
Include any relevant screenshots or videos.