[BUGFIX] Modding (Polymod): Make addCharacter actually set the characters type #3357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reproduced by doing character = CharacterDataParser.fetchCharacter("bf");
PlayState.instance.currentStage.addCharacter(character, CharacterType.BF); |
EliteMasterEric
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
N/A
Briefly describe the issue(s) fixed.
Fixes a call to addCharacter in where if you were to create a custom character in an hscript and then try to add it to the stage, it wouldn't have it's character type get set. Meaning it would not react to any notes being played.
Include any relevant screenshots or videos.
N/A