Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exiting the chart editor doesn't crash the game anymore #3519

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Exiting the chart editor doesn't crash the game anymore #3519

merged 2 commits into from
Oct 4, 2024

Conversation

EliteMasterEric
Copy link
Member

Resolves #2579 .

@EliteMasterEric EliteMasterEric added type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression status: reviewing internally This PR is under internal review and quality assurance testing labels Oct 1, 2024
@EliteMasterEric EliteMasterEric added this to the 0.5.2 milestone Oct 1, 2024
@EliteMasterEric EliteMasterEric self-assigned this Oct 1, 2024
@ninjamuffin99 ninjamuffin99 force-pushed the develop branch 2 times, most recently from e0b1b01 to 410cfe9 Compare October 4, 2024 01:25
@ninjamuffin99 ninjamuffin99 force-pushed the bugfix/chart-editor-notification-crash branch from 2ed5a41 to 50942a3 Compare October 4, 2024 16:37
@ninjamuffin99 ninjamuffin99 force-pushed the bugfix/chart-editor-notification-crash branch from 50942a3 to c59f3fa Compare October 4, 2024 16:38
@ninjamuffin99 ninjamuffin99 merged commit bc8f506 into develop Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninjamuffin99 ninjamuffin99 Awaiting requested review from ninjamuffin99

Assignees

@EliteMasterEric EliteMasterEric

Labels
status: reviewing internally This PR is under internal review and quality assurance testing type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression
Projects
None yet
Milestone
0.5.2
Development

Successfully merging this pull request may close these issues.
2 participants
@EliteMasterEric @ninjamuffin99