Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Replace hmm with HxPKG #3741

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

doggogit
Copy link
Contributor

@doggogit doggogit commented Oct 20, 2024

Does this PR close any issues? If so, link them below.

#2341

Briefly describe the issue(s) fixed.

Should remedy issues with the compiler reporting that libs are missing, when they aren't, just like the issue above.

Brief description

HxPKG, just like hmm, is a Haxe library/module manager that installs libraries with a singular command, locally.

Difference between hmm and HxPKG is that it's self contained, meaning it doesn't other dependencies to work, it's regularly maintained, it automatically sets up hxcpp without external commands or user input, etc.

For more commands on how to use HxPKG, read here.

If you guys have anything to report, you can report it here or make an issue on @CobaltBar's HxPKG repo here.

Changelog:

  • Replaced hmm with HxPKG
  • Updated documentation to match the current setup procedure with HxPKG (it's pretty similar)
  • Adapted all workflow files to work with HxPKG
  • Updated HaxelibVersions.hx to work with HxPKG
  • Edited the silly comment in Constants.hx to say HxPKG and not hmm 😝
  • Removed the lime setup step as the game compiles fine without it
  • Removed an extra space within TROUBLESHOOTING.md
  • Included license links for both funkin.art and funkin.assets

Important

Please do double check if all the workflow files and edited source code files work properly, as far as we're concerned, they should be fine.

Special Thanks

@CobaltBar for HxPKG
@lemz1 for editing the macros to work with HxPKG

Include any relevant screenshots or videos.

N/A

@github-actions github-actions bot added documentation Issue/PR modifies documentation or README files large A large pull request with more than 100 changes labels Oct 20, 2024
@biomseed
Copy link

That issue happens because hxCodec needs to be installed globally, by the way

@doggogit
Copy link
Contributor Author

doggogit commented Oct 20, 2024

That issue happens because hxCodec needs to be installed globally, by the way

It doesn't need to be installed globally

HxPKG remedies that issue as it's something with some flag, I don't exactly know..

@CobaltBar
Copy link

CobaltBar commented Oct 20, 2024

woah its real

i haven't tested installing hxCodec with hxpkg

@NotHyper-474
Copy link
Contributor

NotHyper-474 commented Oct 20, 2024

That issue happens because hxCodec needs to be installed globally, by the way

I'm pretty sure that's been resolved internally already anyway HaxeFoundation/haxelib#618, although seems like we'll still have to deal with it for a while: polybiusproxy/hxCodec#300 (comment)

@CobaltBar
Copy link

haxe moment
i'll just add a thing to force global installation of hxCodec

@biomseed
Copy link

haxe moment i'll just add a thing to force global installation of hxCodec

You can't do that with hmm

@doggogit
Copy link
Contributor Author

haxe moment i'll just add a thing to force global installation of hxCodec

You can't do that with hmm

This PR uses HxPKG, so, it'll be a thing for HxPKG, not for hmm

@CobaltBar
Copy link

CobaltBar commented Oct 20, 2024

Extra info
hxpkg works in github actions
to install the packages for testing along with the ones for testing its hxpkg install unit

@doggogit
Copy link
Contributor Author

That issue happens because hxCodec needs to be installed globally, by the way

I'm pretty sure that's been resolved internally already anyway HaxeFoundation/haxelib#618, although seems like we'll still have to deal with it for a while: polybiusproxy/hxCodec#300 (comment)

HxPKG should hopefully force hxCodec to be installed globally if detected within .hxpkg

This is a temporary fix until Haxe 5.0 comes out

@CobaltBar
Copy link

CobaltBar commented Oct 20, 2024

That issue happens because hxCodec needs to be installed globally, by the way

I'm pretty sure that's been resolved internally already anyway HaxeFoundation/haxelib#618, although seems like we'll still have to deal with it for a while: polybiusproxy/hxCodec#300 (comment)

HxPKG should hopefully force hxCodec to be installed globally if detected within .hxpkg

This is a temporary fix until Haxe 5.0 comes out

hxCodec is always installed globally through hxpkg
not ideal but I can't do much about it

@doggogit
Copy link
Contributor Author

If someone could teach me how to re-base (so I can delete that pesky CHANGELOG commit) and sync branches from the correct branch, that'd be fuckin' wonderful LOL

@doggogit doggogit closed this Oct 23, 2024
@github-actions github-actions bot added small A small pull request with 10 or fewer changes and removed large A large pull request with more than 100 changes labels Oct 23, 2024
@doggogit doggogit reopened this Oct 23, 2024
@github-actions github-actions bot added large A large pull request with more than 100 changes haxe Issue/PR modifies game code and removed small A small pull request with 10 or fewer changes labels Oct 23, 2024
@doggogit
Copy link
Contributor Author

@ninjamuffin99 sorry for the @, but, since you're the Git guru around here, is there a way you can fix the "duplicate" commits from appearing?

@doggogit
Copy link
Contributor Author

Squashed the commits, did a few changes, this should be a-okay now!

doggogit and others added 3 commits November 3, 2024 00:36
Co-authored-by: CobaltBar <79053181+CobaltBar@users.noreply.github.com>
Co-authored-by: lemz1 <ismael.amjad07@gmail.com>
Keeping the cache in, as that's important, but the setup isn't, as HxPKG automatically sets up hxcpp for you
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issue/PR modifies documentation or README files haxe Issue/PR modifies game code large A large pull request with more than 100 changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants