feat: New Icon +Sun Valley theming in configurator.py #18
Conversation
|
That. That is so cool! Can you make an icon with the new curved clock icon and upload here? I'll try adding suggestions so that I could help you in this. |
|
Can you explain what curved clock icon you mean? |
|
@not-nef He means the icon you put on the banner. |
|
Ah, oke |
|
Done! @im-coder-lg |
|
the uploaded version is transparent |
|
That. Is. Excellent. Let's get this PR ready for merging! @not-nef can you test the new icon on macOS? We'll manage on Windows. |
|
macos doesnt display icons for programs @im-coder-lg |
|
What about the dock? PS: My commit incoming! |
@not-nef the changes can be added in this branch, and if you want to make a PR, first inform me so that I will start the commit regulating process. Description: This is originally coded by @not-nef and this is a visual overhaul of the old configuration window, which didn't use the Sun Valley theming TimerX's main window does. This works on macOS and Windows 7(hope this works on Windows 11 too) and I am testing it on Ubuntu 21.10 ARM64(meaning the Raspberry Pi). If the test succeeds, you will see a message on the official PR: sumeshir26#18.
|
Also, @not-nef from now, create a new branch from the |
|
Title change request to 
This could be the icon size. High res, don't you think? |
sumeshir26
changed the title
|
@not-nef @im-coder-lg I reallay like the new icon but I am not so sure about the new banner. I will create a new banner with the new icon but with the existing style of the current banner. |
Done! |
|
@not-nef The icon's background is too dark, can you make it lighter? It dosent look good on the Taskbar. |
sumeshir26
changed the title
Can do later this day |
i like the banner but ok |
|
Okay I'm back, what did I miss other than the title change, banner change and et cetera? |
|
Done @sumeshir26 |
|
: |
|
Can you share a transparent one or try using something like Favicon Generator to make the icon? |
the version on my fork is transparent |
|
Okay will inspect that. After some tests, I say we'll be good to merge the PR(Note to self: DO NOT MERGE THE PR WITHOUT PERMISSION cuz it might happen) |
|
Also, @not-nef can we increase the configuration length by maybe 5 pixels? Will test that and tell the outcome here too. |
|
dunno what that means but ok |
|
merge? |
|
Get your changes on the base branch. That's the way to get your changes to TimerX. |
|
woah, im a contributor lesgo |
|
Congrats bro! I recommend you search for more features to add, then open an issue and then, go ahead with a PR! Would love to see more contributions from you and I'd love to review them! |
|
i think ill get my hands on a settings page next |
|
Ah, we are aiming for the same thing! Let's use the configurator file for the same work. |
|
ok, gonna start in an hour or so |
|
I kinda think @sumeshir26 finished the settings part(there's a settings branch) but I need you to test it, and improve it like modifying the sizes, locking maximization and more. |
|
Then, we can open another PR to the settings branch to get your changes there. |
|
Well, an about page? |
|
That needs some extensive code to add links, an Ok button and more, right? |
|
@im-coder-lg i checked the settings branch and it literally contains nothing (only a label and some theme config) so i will recode the page |
shouldnt be too hard |
|
Ok, looking forward to the PR! 😁 |
|
Locallay, I have gotten far on the settings page. I recebtly added sving to json fies nef could work |
|
on the about page |
|
i will still do a recode, i have an idea in mind |
Adds a new icon and adds Sun Valley style to entry
Fixes #15