Settings window

[not-nef]

THIS PR IS NOT READY FOR MERGING, its just for progress tracking.

Check this out:

:

[im-coder-lg]

Woah, is that Windows 11? Cool!
I got some reviews for you, they are coming! Also, this best be merged to the settings branch so that it's kinda easier to revert back when everything gets messed up.

[im-coder-lg]

Also, too much of additions, wonder if we could merge this...

[not-nef]

Also, too much of additions, wonder if we could merge this...

wdym too much additions?

[sumeshir26]

could you replace the current dark theme bhutton with the settings one?

[not-nef]

could you replace the current dark theme bhutton with the settings one?

sure

[sumeshir26]

Here are the things that should be added to the settings window

• Theme
• Slider for transperency
• Option to play sound after timer ends
• Option to send notification
• JSON or YAML sefttings saving

[not-nef]

TODOS:

1. Make sure that icons get synced
2. Add option to pin / unpin
3. Add labels and icons
4. Position everything so it doesnt look absolutely stupid

[not-nef]

5. everything sumeshir mentioned above

[not-nef]

@sumeshir26 wdym json and yaml setting saving? i just did it with a text file.

[sumeshir26]

Then we need to have like 10 text files. You can do it woth txt files, I will migrate to Json afterwards

[not-nef]

just tell me how to do it

[im-coder-lg]

Option to play sound after timer ends

This doesn't seem to work on my Windows 7 PC as well as my Raspberry Pi running Ubuntu Impish. Need to inspect this.

[im-coder-lg]

JSON or YAML sefttings saving

Let's use YAML, it doesn't have a lot of curly braces that confuse me.

[not-nef]

now button texture syncs

[not-nef]

i will continue tomorrow

[not-nef]

Makin Progress :)

[sumeshir26]

Great work so far!

[not-nef]

btw @sumeshir26 we can do it with one text file if we only read specific lines, so you dont have to migrate it.

[sumeshir26]

Okay, do it how you think is best...

[not-nef]

thx

[not-nef]

bro this took ages

[not-nef]

@sumeshir26 what transparency do you mean?

[im-coder-lg]

Hey I'm back, need to test this soon. Can I change the base branch to the settings branch? Might make it kinda more easy, right?

[im-coder-lg]

I can't explain tho, feeling blank on the branch change. Maybe not.

[not-nef]

@im-coder-lg i would keep it like it is and then merge it in the master branch when its done.

[not-nef]

ive found a fix!

[not-nef]

https://stackoverflow.com/questions/50012062/when-using-tkinter-error-tclerror-image-pyimage8-doesnt-exist

oh, yep thats the one i found

[sumeshir26]

@not-nef Can you give me collaborator access to your fork?

[not-nef]

Its done.

[not-nef]

@sumeshir26 gave you acces, but this pr is ready for merging

[im-coder-lg]

Bro remove configurator.py from setup.py!!! cx_Freeze is failing!

[im-coder-lg]

I'll commit that

[im-coder-lg]

Fixed.

[not-nef]

how did you commit?

[im-coder-lg]

I finally declare LGTM! Congrats @not-nef! Also thanks for this!

[not-nef]

np, this was a fun journey!

[not-nef]

@sumeshir26 merge?

[im-coder-lg]

how did you commit?

Collaborator access you gave me. It was of real value.

[im-coder-lg]

np, this was a fun journey!

yeah too fun

@sumeshir26 merge?

On New Year. That'd make it crazily special. We'd better merge #26 too, a lot of additions that's why.

[not-nef]

coolio, gettin pretty close to 1.0 right?

[im-coder-lg]

Actually, it's 0.9 right now but it might change anytime!

[sumeshir26]

@not-nef Can you share a final screenshot?

[not-nef]

Its done.

@sumeshir26

[sumeshir26]

@not-nef Thank You!

[not-nef]

LETS GOOO

[not-nef]

@sumeshir26 is there some way to apply for collaborator acces?

[im-coder-lg]

Only the maintainer can give collaborator access. But you have to be careful, 'cause you might end up doing some mistakes, that's why I use PRs for new things on the website and immediate commits to fix simple things like CI/CD.

[not-nef]

i would use prs too but it would be cool to have collaborator acces for things like #28