Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Update+add documentation #42

Merged
merged 14 commits into from
Jan 11, 2022
Merged

chore(docs): Update+add documentation #42

merged 14 commits into from
Jan 11, 2022

Conversation

im-coder-lg
Copy link
Member

For now, it's just the first commit, I'll continue soon, maybe tomorrow.

i am backing up
@netlify
Copy link

netlify bot commented Jan 9, 2022

✔️ Deploy Preview for timerx-app canceled.

🔨 Explore the source changes: d103e2d

🔍 Inspect the deploy log: https://app.netlify.com/sites/timerx-app/deploys/61dd398db32fed00079d96ff

@im-coder-lg
Copy link
Member Author

im-coder-lg commented Jan 9, 2022

WIP

Browser metadata
Path:      /docs/contributing
Browser:   Chrome 96.0.4664.137 on Windows 7
Viewport:  1269 x 655 @1x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@im-coder-lg
Copy link
Member Author

Ah that's me, can you approve me as a reviewer?

@not-nef
Copy link
Member

not-nef commented Jan 9, 2022

Yo i can commit cool

@im-coder-lg
Copy link
Member Author

I'll manage from here, can you just supervise?

@im-coder-lg
Copy link
Member Author

No offense, I need some help frankly.

@im-coder-lg
Copy link
Member Author

Yo i can commit cool

Collaborator rights 😎

@im-coder-lg im-coder-lg changed the title Update documentation chore(docs): Update+add documentation Jan 9, 2022
@im-coder-lg
Copy link
Member Author

Renamed the title semantically, how's that?

@im-coder-lg im-coder-lg self-assigned this Jan 9, 2022
@im-coder-lg im-coder-lg added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 9, 2022
@not-nef
Copy link
Member

not-nef commented Jan 9, 2022

semantically?

@im-coder-lg
Copy link
Member Author

The cz c way? It's semantic.

@not-nef
Copy link
Member

not-nef commented Jan 9, 2022

what does it mean

@im-coder-lg
Copy link
Member Author

If you compare Add my own image to my blog and feat(blog): my own image, you will say the second one is better than the first. This is semantic committing.
Also @sumeshir26 thanks for approving me as a reviewer.

@im-coder-lg
Copy link
Member Author

im-coder-lg commented Jan 10, 2022

Is the contributing guide fine? Any changes to add?
Link: https://deploy-preview-42--timerx-app.netlify.app/docs/contributing

Open Deploy Preview · Mark as Resolved

@sumeshir26
Copy link
Member

@im-coder-lg
Copy link
Member Author

No, that's the landing page. We can use it as a welcome page, right>

Browser metadata
Path:      /docs/intro
Browser:   Chrome 96.0.4664.137 on Windows 7
Viewport:  1269 x 655 @1x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@im-coder-lg
Copy link
Member Author

Browser metadata is irritating. Also, I'll edit the intro page, can you add the homepage link to the README and the repo description?

@sumeshir26
Copy link
Member

Ok

@im-coder-lg
Copy link
Member Author

im-coder-lg commented Jan 10, 2022 via email

I need some text, any ideas?

No breaking changes.
Need to add some extra things, I need to switch workspaces.
Next, common issues? But anyway, 🎉!
@im-coder-lg
Copy link
Member Author

im-coder-lg commented Jan 10, 2022

Can anyone else test c288b78? Also, any other ideas?

Browser metadata
Path:      /docs/compile/
Browser:   Firefox 95.0 on Windows 7
im-coder-lg: no respect for personal privacy, eh?
Viewport:  1304 x 683 @1x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@im-coder-lg
Copy link
Member Author

But that doesn't have tables, that's why I asked. It shows a board, not a table-like view. I mean that it has to look like an Excel spreadsheet.

@im-coder-lg
Copy link
Member Author

Trello offers a GitHub integration as well as tabled organizing of cards. But I think we could use something that's already on GitHub.

@im-coder-lg
Copy link
Member Author

im-coder-lg commented Jan 10, 2022

I removed the old review, it told that it was pending, so dismissed it with "Resolved".

@im-coder-lg
Copy link
Member Author

I have to be changing the footer!

Copy link

@netlify netlify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A reviewer(@im-coder-lg) left a comment:

Ready for merge! Maybe I'll modify the homepage later.

Browser metadata
Path:      /docs/compile
Browser:   Chrome 97.0.4692.71 on Windows 7
Viewport:  1304 x 665 @1x
Language:  en-GB
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@im-coder-lg
Copy link
Member Author

Wait, replit guide needed!

Copy link

@netlify netlify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A reviewer left a comment:
@im-coder-lg's comment
screenshot

How's that? Also, the Deploy Preview's font did that, don't question me.
LGTM

Browser metadata
Path:      /docs/contributing#replit
Browser:   Chrome 97.0.4692.71 on Windows 7
Viewport:  1304 x 665 @1x
Language:  en-GB
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@im-coder-lg
Copy link
Member Author

Hey how do we add custom Unicode emojis to Chrome? Becuase I hopped onto a live BrowserStack device running macOS Monterey, Safari 15.1 and they allowed the emoji.

Browser metadata
Path:      /docs/contributing#replit
Browser:   Chrome 97.0.4692.71 on Windows 7
Viewport:  1304 x 665 @1x
Language:  en-GB
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@im-coder-lg
Copy link
Member Author

Oh, it's globally for macOS.

Browser metadata
Path:      /docs/contributing#replit
Browser:   Chrome 97.0.4692.71 on Windows 7
Viewport:  1304 x 665 @1x
Language:  en-GB
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@im-coder-lg
Copy link
Member Author

/ping @sumeshir26 can you review please?

@sumeshir26
Copy link
Member

@im-coder-lg Did you add the screenshot?

@im-coder-lg
Copy link
Member Author

im-coder-lg commented Jan 11, 2022

Did you add the screenshot?

No, I will add it later. It seems like we all have a busy schedule. I will be busy till lunchtime.

Starting now.

@im-coder-lg
Copy link
Member Author

Merge this PR after my commit on the master branch. CI fails and I know why.

@im-coder-lg
Copy link
Member Author

Don't, I need to update docs.

Adhering to the recent changes.
@im-coder-lg
Copy link
Member Author

Fixed, ready.

@im-coder-lg im-coder-lg added the ready Ready for merge. label Jan 11, 2022
@im-coder-lg
Copy link
Member Author

Ready for merge!

@sumeshir26 sumeshir26 merged commit b474aab into master Jan 11, 2022
@sumeshir26 sumeshir26 deleted the docs-upd branch January 11, 2022 08:22
@sumeshir26 sumeshir26 added approved This pull request is ready to merge and removed ready Ready for merge. labels Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This pull request is ready to merge documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants