-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): Update+add documentation #42
Conversation
i am backing up
✔️ Deploy Preview for timerx-app canceled. 🔨 Explore the source changes: d103e2d 🔍 Inspect the deploy log: https://app.netlify.com/sites/timerx-app/deploys/61dd398db32fed00079d96ff |
WIP Browser metadata
|
Ah that's me, can you approve me as a reviewer? |
Yo i can commit cool |
I'll manage from here, can you just supervise? |
No offense, I need some help frankly. |
Collaborator rights 😎 |
Renamed the title semantically, how's that? |
semantically? |
The |
what does it mean |
If you compare |
Is the contributing guide fine? Any changes to add? |
Can we remove this: https://deploy-preview-42--timerx-app.netlify.app/docs/intro? |
No, that's the landing page. We can use it as a welcome page, right> Browser metadata
|
Browser metadata is irritating. Also, I'll edit the intro page, can you add the homepage link to the README and the repo description? |
Ok |
Any ideas on the intro page? Need some text that's why.
|
I need some text, any ideas? No breaking changes.
Need to add some extra things, I need to switch workspaces.
Next, common issues? But anyway, 🎉!
Can anyone else test c288b78? Also, any other ideas? Browser metadata
|
But that doesn't have tables, that's why I asked. It shows a board, not a table-like view. I mean that it has to look like an Excel spreadsheet. |
Trello offers a GitHub integration as well as tabled organizing of cards. But I think we could use something that's already on GitHub. |
I removed the old review, it told that it was pending, so dismissed it with "Resolved". |
I have to be changing the footer! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A reviewer(@im-coder-lg) left a comment:
Ready for merge! Maybe I'll modify the homepage later.
Browser metadata
Path: /docs/compile
Browser: Chrome 97.0.4692.71 on Windows 7
Viewport: 1304 x 665 @1x
Language: en-GB
Cookies: Enabled
Wait, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A reviewer left a comment:
@im-coder-lg's comment
How's that? Also, the Deploy Preview's font did that, don't question me.
LGTM
Browser metadata
Path: /docs/contributing#replit
Browser: Chrome 97.0.4692.71 on Windows 7
Viewport: 1304 x 665 @1x
Language: en-GB
Cookies: Enabled
Hey how do we add custom Unicode emojis to Chrome? Becuase I hopped onto a live BrowserStack device running macOS Monterey, Safari 15.1 and they allowed the emoji. Browser metadata
|
Oh, it's globally for macOS. Browser metadata
|
/ping @sumeshir26 can you review please? |
@im-coder-lg Did you add the screenshot? |
No, I will add it later. It seems like we all have a busy schedule. I will be busy till lunchtime. Starting now. |
Merge this PR after my commit on the master branch. CI fails and I know why. |
Don't, I need to update docs. |
Adhering to the recent changes.
Fixed, ready. |
From pyinstaller to cx_Freeze
Ready for merge! |
For now, it's just the first commit, I'll continue soon, maybe tomorrow.