Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better settings #62

Merged
merged 6 commits into from
Jan 23, 2022
Merged

Add better settings #62

merged 6 commits into from
Jan 23, 2022

Conversation

not-nef
Copy link
Member

@not-nef not-nef commented Jan 23, 2022

@sumeshir26 This is ready for merging

@netlify
Copy link

netlify bot commented Jan 23, 2022 •
edited
Loading

✔️ Deploy Preview for timerx-app canceled.

🔨 Explore the source changes: e586b46

🔍 Inspect the deploy log: https://app.netlify.com/sites/timerx-app/deploys/61ed6d13fb56bc0007b1966a

@not-nef
Copy link
Member Author

not-nef commented Jan 23, 2022

With every pr, this app more looks like a uwp app!

im-coder-lg
im-coder-lg approved these changes Jan 23, 2022
View reviewed changes
Copy link
Member

@im-coder-lg im-coder-lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@not-nef
Copy link
Member Author

not-nef commented Jan 23, 2022

Lets goo

@im-coder-lg
Copy link
Member

Wait, an even better idea on the about page - why not add it as a tab to the settings window? I will try this though.

@not-nef
Copy link
Member Author

not-nef commented Jan 23, 2022

Wait, an even better idea on the about page - why not add it as a tab to the settings window? I will try this though.

I will do it, finish your update system @im-coder-lg

@not-nef
Copy link
Member Author

not-nef commented Jan 23, 2022

Done! @im-coder-lg

@im-coder-lg
Copy link
Member

im-coder-lg commented Jan 23, 2022 •
edited
Loading

That's great, but why does the clock font go dark even in dark mode?

@im-coder-lg
Copy link
Member

im-coder-lg commented Jan 23, 2022 •
edited
Loading

With every pr, this app more looks like a uwp app!

Seems like the installer's the only thing left out though. If we theme that to Sun Valley, it will look great!

@not-nef
Copy link
Member Author

not-nef commented Jan 23, 2022

That's great, but why does the clock font go dark even in dark mode?

Oh, have to check

@not-nef
Copy link
Member Author

not-nef commented Jan 23, 2022

That's great, but why does the clock font go dark even in dark mode?

What clock font do you mean? Can you send a screenshot?

@im-coder-lg
Copy link
Member

One min...

@not-nef
Copy link
Member Author

not-nef commented Jan 23, 2022

Everything seems to work for me

@im-coder-lg
Copy link
Member

Oh never mind, it's random. So a restart would fix that. Can you check TimerX-App/TimerX-Update-Test#2?

@not-nef
Copy link
Member Author

not-nef commented Jan 23, 2022

Ah i see what you mean

@im-coder-lg
Copy link
Member

Anyway, leave it. Soon Windows 7 users will have to switch to Windows 10, so doesn't matter as of now.

@not-nef
Copy link
Member Author

not-nef commented Jan 23, 2022

Oh never mind, it's random. So a restart would fix that. Can you check TimerX-App/TimerX-Update-Test#2?

I fixed it!

@not-nef
Copy link
Member Author

not-nef commented Jan 23, 2022

Anyway, leave it. Soon Windows 7 users will have to switch to Windows 10, so doesn't matter as of now.

Why?

@not-nef
Copy link
Member Author

not-nef commented Jan 23, 2022

@im-coder-lg Done!

@not-nef
Copy link
Member Author

not-nef commented Jan 23, 2022

@sumeshir26 can i merge?

@sumeshir26
Copy link
Member

Could you rename the notebook to tabview or tabframe because the name notebook is confusing
After that, you can merge!

sumeshir26
sumeshir26 approved these changes Jan 23, 2022
View reviewed changes
Copy link
Member

@sumeshir26 sumeshir26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Epic. Looks gut!

@sumeshir26
Copy link
Member

Merge this as feat: Settings with Tabs

@not-nef
Copy link
Member Author

not-nef commented Jan 23, 2022

Okay

@not-nef not-nef merged commit f3e189f into Futura-Py:master Jan 23, 2022
@not-nef not-nef deleted the Better-Settings branch January 23, 2022 15:01
@not-nef
Copy link
Member Author

not-nef commented Jan 23, 2022

My first merge 🎉

@sumeshir26
Copy link
Member

My first merge 🎉

Yay!

@not-nef From next time you can just create a branch on the main repo, not your fork so it is easy to manage for everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@im-coder-lg im-coder-lg im-coder-lg approved these changes

@sumeshir26 sumeshir26 sumeshir26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@not-nef @im-coder-lg @sumeshir26