Fixed sonnet json formatting issue #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
approved these changes
Jun 25, 2024
| return match.group(0).replace("\n", "\\n") | ||
|
|
||
| pattern = r'"(?:[^"\\]|\\.)*"' | ||
| text = re.sub(pattern, replace_newlines, text) |
There was a problem hiding this comment.
TIL repl arg can be a function
| def replace_newlines(match): | ||
| return match.group(0).replace("\n", "\\n") | ||
|
|
||
| pattern = r'"(?:[^"\\]|\\.)*"' |
There was a problem hiding this comment.
Bonus points for regex 101 link
|
|
||
| # escape new lines within strings | ||
| def replace_newlines(match): | ||
| return match.group(0).replace("\n", "\\n") |
There was a problem hiding this comment.
Is there a latent NoneType error here? Can we type hint match with re.Match, and the return as str
There was a problem hiding this comment.
Added a type - I don't think sub will call on None matches
| @@ -184,4 +184,12 @@ def llm_read_json(text: str) -> dict: | |||
| text = "{" + text.split("{", 1)[-1] | |||
| # split anything after the last } | |||
| text = text.rsplit("}", 1)[0] + "}" | |||
|
|
|||
| # escape new lines within strings | |||
There was a problem hiding this comment.
What do you think of re.escape?
There was a problem hiding this comment.
Don't see the connection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #292