Check if a journal name starts with the
#320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
reviewed
Sep 7, 2024
jamesbraza
reviewed
Sep 7, 2024
| @@ -44,7 +44,12 @@ async def _process( | |||
| # remember, if both have docnames (i.e. key) they are | |||
| # wiped and re-generated with resultant data | |||
| return doc_details + DocDetails( # type: ignore[call-arg] | |||
| source_quality=self.data.get(query.journal.casefold(), -1) # type: ignore[union-attr] | |||
There was a problem hiding this comment.
Should we be using casefold?
There was a problem hiding this comment.
I think so? just to be more robust with journal names. @mskarlin thoughts?
There was a problem hiding this comment.
yup that's what we've been using on title comparisons!
|
Thanks @geemi725! Can you port over the unit test too? |
whitead
approved these changes
Sep 8, 2024
| @@ -299,7 +299,7 @@ async def test_s2_only_fields_filtering(): | |||
| assert not s2_details.source_quality, "No source quality data should exist" # type: ignore[union-attr] | |||
|
|
|||
|
|
|||
| @pytest.mark.vcr | |||
| @pytest.mark.vcr(record_mode="new_episodes") | |||
There was a problem hiding this comment.
Don't think you need this - I was wrong
Suggested change
| @pytest.mark.vcr(record_mode="new_episodes") | |
| @pytest.mark.vcr |
There was a problem hiding this comment.
I think we should let the VCR config in conftest.py be the one source of truth. So I vote we do actually commit this change
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found exceptions where a journal name can start with
thein the JournalQualityDBNow checks the journal name with and without
theCloses #317