Changed to rely on litellm for computing cost #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
approved these changes
Sep 8, 2024
paperqa/llms.py
Outdated
|
|
||
| async def acomplete(self, prompt: str) -> str: | ||
| async def acomplete(self, prompt: str) -> tuple[str, tuple[int, int]]: |
There was a problem hiding this comment.
Since this is sort of an abstractmethod, can you somehow document what the return type is?
Can make a NamedTuple that is sort of self-documenting, or a docstring
There was a problem hiding this comment.
OK added a new class and revised code to use it
mskarlin
approved these changes
Sep 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title