Chromium and Firefox both fail a11y on buttons — Option 2 #6468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adrian's testing shows both Chromium and Firefox have accessibility problems when `display: contents` is applied to `buttons`. This PR keeps all browsers with most of the accessibility problems fixed as having full support — while marking each bright green box with a clear number that corresponds with the issue that web developers should be aware of. It sets Safari to supporting as well, to match what other browsers are getting.
|
Closing as this has been resolved in a separate change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adrian's testing shows both Chromium and Firefox have accessibility problems when
display: contentsis applied tobuttons.This PR keeps all browsers with most of the accessibility problems fixed as having full support — while marking each bright green box with a clear number that corresponds with the issue that web developers should be aware of. It sets Safari to supporting as well, to match what other browsers are getting.