Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update css-text-box-trim.json #7216

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Update css-text-box-trim.json #7216

merged 1 commit into from
Dec 3, 2024

Conversation

jensimmons
Copy link
Contributor

Safari 18.2 adds support for text-box, text-box-trim, and text-box-edge. This PR also updates the title of the feature — since the text-box shorthand is a better way to use this. And the PR updates the description to explain this includes text-box-trim, and text-box-edge... and describing more accurately what it does. I also removed the reference to leading-trim, since 1) the early draft never shipped in customer-facing browsers, and 2) the name change is very old news.

Safari 18.2 adds support for `text-box`, `text-box-trim`, and `text-box-edge`. This PR also updates the title of the feature — since the `text-box` shorthand is a better way to use this. And the PR updates the description to explain this includes `text-box-trim`, and `text-box-edge`... and describing more accurately what it does. I also removed the reference to `leading-trim`, since 1) the early draft never shipped in customer-facing browsers, and 2) the name change is very old news.
@jensimmons
Copy link
Contributor Author

Screenshot 2024-12-02 at 2 28 37 PM

Is the "Limited availability across major browsers" box automated? How do we make it go away? This is a feature developers can use today to progressively enhance sites in browser with support. Warning them to not use it is unnecessary.

@Fyrd Fyrd merged commit 6bf9604 into Fyrd:main Dec 3, 2024
1 check passed
@Fyrd
Copy link
Owner

Fyrd commented Dec 3, 2024

Looks good, thanks!

Yes, that's the the Baseline banner that is added automatically. I don't think it's warning users not use a feature, just effectively summarizes the current browser support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants