Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: get all valid listings function #129

Merged
merged 4 commits into from
May 16, 2024
Merged

Fix: get all valid listings function #129

merged 4 commits into from
May 16, 2024

Conversation

karacurt
Copy link
Contributor

🐵 Description

  • Fix get all valid listings function to check if marketplace is owner of the asset

@karacurt karacurt marked this pull request as draft May 15, 2024 22:47
ogarciarevett
ogarciarevett requested changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@ogarciarevett ogarciarevett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add 1 simple flow to the unit tests to check pls

@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented May 15, 2024 •
edited
Loading

Fix: get all valid listings function

Generated at commit: 814b81b56bdb5d1dc7fbd096fc45f6d6d7e4e423

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
10
38
52
Dependencies Critical
High
Medium
Low
Note
Total		 1
0
0
1
238
240

For more details view the full report in OpenZeppelin Code Inspector

ogarciarevett
ogarciarevett approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@ogarciarevett ogarciarevett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karacurt karacurt marked this pull request as ready for review May 16, 2024 00:16
@karacurt karacurt merged commit 9c97b9c into main May 16, 2024
1 check passed
@ogarciarevett ogarciarevett deleted the fix/get-all-valid-listings branch May 16, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogarciarevett ogarciarevett ogarciarevett approved these changes

@vasinl124 vasinl124 Awaiting requested review from vasinl124 vasinl124 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karacurt @ogarciarevett