Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make reward to support mulitple rewards #93

Merged
merged 26 commits into from
Apr 4, 2024
Merged

feat: Make reward to support mulitple rewards #93

merged 26 commits into from
Apr 4, 2024

Conversation

vasinl124
Copy link
Contributor

Issue: resolves

🐵 Description

🙊 Checklist:

  • I have added tests proving my fix is effective or that my feature works
  • Contract deployed to testnet(only for new contracts)

@vasinl124 vasinl124 marked this pull request as draft March 29, 2024 23:57
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Mar 30, 2024 •
edited
Loading

feat: Make reward to support mulitple rewards

Generated at commit: 3e518108655be5d105b94c1e0a530e257c0d567b

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 1
1
0
4
30
36
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
1
197
198

For more details view the full report in OpenZeppelin Code Inspector

ogarciarevett
ogarciarevett approved these changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@ogarciarevett ogarciarevett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just 2 small suggestions

contracts/soulbounds/ERC1155RewardSoulbound.sol Outdated
// tokenRewards[_tokenId].rewardAmount = _newAmount;
}

function updateReward() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this with a TODO for the part 2

contracts/soulbounds/ERC1155RewardSoulbound.sol Outdated Show resolved Hide resolved
contracts/soulbounds/ERC1155RewardSoulbound.sol Outdated Show resolved Hide resolved
ogarciarevett
ogarciarevett requested changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@ogarciarevett ogarciarevett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the cache_hardhat-zk of the differences please and add it to the .gitignore file

@vasinl124 vasinl124 marked this pull request as ready for review April 4, 2024 22:00
ogarciarevett
ogarciarevett approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@ogarciarevett ogarciarevett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vasinl124 vasinl124 merged commit 4d5d462 into develop Apr 4, 2024
1 check passed
@vasinl124 vasinl124 deleted the feat/reward-contract branch April 4, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogarciarevett ogarciarevett ogarciarevett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vasinl124 @ogarciarevett