Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Admin / Classifications / mostly Styling update #11427

Open
1 task done
Jerryescandon opened this issue Aug 30, 2024 · 5 comments
Open
1 task done

✨ Admin / Classifications / mostly Styling update #11427

Jerryescandon opened this issue Aug 30, 2024 · 5 comments
Assignees
Labels
feature New feature or request.

Comments

@Jerryescandon
Copy link

Jerryescandon commented Aug 30, 2024

✨ Feature

Update styling of the Community pages, standardize the way things work, and bring it in line with the overall platform's look and feel.

Out of scope for this issue (don't build this even if it's in the design)

  • Moving to the new nav
  • Updates to the table component
  • Adding "searchable" to the classification model (and associated UI)
  • Advanced (or advanced tools) tab
  • Changes to table search and filter

🎨 Design

Figma file by @Jerryescandon

✅ Acceptance Criteria

  • Classifications page (/admin/settings/classifications)

    • Header (background, H1 & breadcrumb)
    • H2 and content styling
    • Remove "edit" column, add edit link to the "Name" column instead
  • Create classification (/admin/settings/classifications/create)

    • Header (background, H1 & breadcrumb)
    • H2 and content styling
  • Edit a community page (/admin/classifications/:id:/edit)

    • (should use same component as Create Classification page)
  • New page - Classifications information (/admin/classifications/:id:)

    • Header (background, H1 & breadcrumb)
    • H2 and content styling
    • Only one tab for now
    • Inline form for displaying information and editing
  • Mobile view for all pages

  • Design Review by @Jerryescandon

Blockers

Blocked by

  1. feature
    vd1992
@Jerryescandon Jerryescandon added the feature New feature or request. label Aug 30, 2024
@Jerryescandon Jerryescandon added this to the Admin migration milestone Aug 30, 2024
Copy link

github-actions bot commented Aug 30, 2024

Status: Ready to merge ✔️

Issues blocking this PR:


This comment was automatically written by the Blocking Issues bot, and this PR will be monitored for further progress.

@Jerryescandon Jerryescandon added the blocked: design Blocked by missing designs. label Sep 9, 2024
@gobyrne gobyrne changed the title ✨ New nav - Classifications ✨ No new nav - Classifications Sep 12, 2024
@gobyrne gobyrne added review in refinement Ready to be looked at and pulled into "ready to dev" and removed blocked: design Blocked by missing designs. labels Sep 12, 2024
@gobyrne
Copy link
Member

gobyrne commented Sep 12, 2024

This one also ready for your review @NienkeBr (no rush)

@gobyrne
Copy link
Member

gobyrne commented Sep 16, 2024

@Jerryescandon maybe only let people select "group & level" during the Create step. Actually, let's think about it what fields should be "not editable" after creation.

Then we have the design question about how to show them during create step. But also, seing the on the View page, but not the edit page?

@gobyrne
Copy link
Member

gobyrne commented Sep 16, 2024

@Jerryescandon *create page is missing level & salary. Maybe clean up the "display names" too.

@Jerryescandon
Copy link
Author

Updated screenshots:

  • Added group and level and salary to create page
  • Removed display name fields

@Jerryescandon Jerryescandon changed the title ✨ No new nav - Classifications ✨ Admin / Classifications / Styling update Sep 18, 2024
@gobyrne gobyrne changed the title ✨ Admin / Classifications / Styling update ✨ Admin / Classifications / mostly Styling update Sep 19, 2024
@vd1992 vd1992 removed the review in refinement Ready to be looked at and pulled into "ready to dev" label Sep 23, 2024
@gobyrne gobyrne added blocked: design Blocked by missing designs. review in refinement Ready to be looked at and pulled into "ready to dev" and removed blocked: design Blocked by missing designs. review in refinement Ready to be looked at and pulled into "ready to dev" labels Sep 26, 2024
@github-actions github-actions bot added the blocked: dependencies Blocked by other issues. label Oct 3, 2024
@github-actions github-actions bot removed the blocked: dependencies Blocked by other issues. label Oct 18, 2024
@esizer esizer self-assigned this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request.
Projects
Status: 🏗 In progress
Development

No branches or pull requests

5 participants