We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to the Hero component. All variants now allow for breadcrumbs and non-tab variants optionally allow for body overlap of the hero.
The pattern that we're going for:
Out of scope: Update to the mobile tab component
Which makes for all these variants :
Mobile
So only 4 variants for mobile
Hero component figma
@JoshBeveridge
Here are screenshots, just adding it because Figma was aligning the tabs incorrectly sometimes... if it looks weird, check back here or ask Josh.
Desktop variants
Mobile variants
breadcrumb placement updated
Storybook story
Design review @JoshBeveridge
The text was updated successfully, but these errors were encountered:
Overlap comparison
Sorry, something went wrong.
vd1992
Successfully merging a pull request may close this issue.
✨ Feature
Updates to the Hero component. All variants now allow for breadcrumbs and non-tab variants optionally allow for body overlap of the hero.
The pattern that we're going for:
Out of scope:
Update to the mobile tab component
🕵️ Details
Desktop options
Which makes for all these variants :
Mobile options
Mobile
So only 4 variants for mobile
🎨 Design
Hero component figma
@JoshBeveridge
Here are screenshots, just adding it because Figma was aligning the tabs incorrectly sometimes... if it looks weird, check back here or ask Josh.
Desktop
Mobile
Suggested implementation
✅ Acceptance Criteria
Desktop variants
Mobile variants
breadcrumb placement updated
Storybook story
Design review @JoshBeveridge
The text was updated successfully, but these errors were encountered: