Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Site-wide hero update #11344

Closed
14 tasks
petertgiles opened this issue Aug 22, 2024 · 1 comment · Fixed by #11713
Closed
14 tasks

✨ Site-wide hero update #11344

petertgiles opened this issue Aug 22, 2024 · 1 comment · Fixed by #11713
Assignees
Labels
feature New feature or request.

Comments

@petertgiles
Copy link
Contributor

petertgiles commented Aug 22, 2024

✨ Feature

Updates to the Hero component. All variants now allow for breadcrumbs and non-tab variants optionally allow for body overlap of the hero.

The pattern that we're going for:

  1. Pages that are single forms have overlap and dashboards also have overlap
  2. Tabs are reserved for page sets with multiple chunks of data
  3. All other pages have the standard header

Out of scope:
Update to the mobile tab component

🕵️ Details

Desktop options

  1. Tabs, no tabs, or no tabs with overlap
  2. Centered or not
  3. Image or not

Which makes for all these variants :

  1. Tabs, no image
  2. Tabs, with image
  3. Tabs, no image, Centered
  4. Tabs, with image, Centered
  5. No tabs, no image
  6. No tabs, with image
  7. No tabs, no image, Overlap
  8. No tabs, with image, Overlap
  9. No tabs, no image, Centered
  10. No tabs, with image, Centered
  11. No tabs, no image, Centered, Overlap
  12. No tabs, with image, Centered, Overlap

Mobile options

Mobile

  1. Tabs or no
  2. Image or no
  3. Always centered

So only 4 variants for mobile

  1. Tabs, no image
  2. Tabs, with image (not in design file, but please dev it)
  3. No tabs, no image
  4. No tabs, with image (not in design file, but please dev it)

🎨 Design

Hero component figma

@JoshBeveridge

Here are screenshots, just adding it because Figma was aligning the tabs incorrectly sometimes... if it looks weird, check back here or ask Josh.

Desktop

image
image

Mobile

image

Suggested implementation

  • Create a new hero component
  • Deprecate the old one

✅ Acceptance Criteria

  • Desktop variants

    • Tabs, no tabs, or no tabs with overlap
    • Centered or not
    • Image or not
    • Buttons or not
  • Mobile variants

    • Tabs, no tabs
    • Image or not
    • Buttons or not
  • breadcrumb placement updated

  • Storybook story

  • Design review @JoshBeveridge

@petertgiles petertgiles added the feature New feature or request. label Aug 22, 2024
@petertgiles petertgiles modified the milestone: Manager accounts Aug 22, 2024
@petertgiles petertgiles added the blocked: design Blocked by missing designs. label Aug 22, 2024
@gobyrne gobyrne removed the blocked: design Blocked by missing designs. label Sep 27, 2024
@gobyrne gobyrne changed the title ✨ Site-wide hero update WIP ✨ Site-wide hero update Sep 27, 2024
@gobyrne gobyrne added the review in refinement Ready to be looked at and pulled into "ready to dev" label Sep 27, 2024
@gobyrne gobyrne removed the review in refinement Ready to be looked at and pulled into "ready to dev" label Sep 27, 2024
@vd1992 vd1992 self-assigned this Oct 7, 2024
@vd1992
Copy link
Contributor

vd1992 commented Oct 7, 2024

Overlap comparison

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request.
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants