Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Admin / Departments / mostly Styling update #11478

Closed
1 task done
Jerryescandon opened this issue Sep 9, 2024 · 2 comments · Fixed by #11853
Closed
1 task done

✨ Admin / Departments / mostly Styling update #11478

Jerryescandon opened this issue Sep 9, 2024 · 2 comments · Fixed by #11853
Assignees
Labels
feature New feature or request.

Comments

@Jerryescandon
Copy link

Jerryescandon commented Sep 9, 2024

✨ Feature

Updating the departments page to the new admin patterns

🕵️ Details

Out of scope for this issue (don't build this even if it's in the design)

  • Updates to the table component
  • Moving to the new nav
  • The "advanced tools" tab and anything in it
  • Filter and search on table

🎨 Design

Figma file by @Jerryescandon

✅ Acceptance Criteria

  • departments page (/admin/settings/departments)

    • Header (background, H1 & breadcrumb)
    • H2 and content styling
    • Reorder the table. Name first, number second
    • Remove "edit" column, add link on the "Name" column (pointing to the information page) instead
  • Create department (/admin/settings/departments/create)

    • Header (background, H1 & breadcrumb)
    • H2 and content styling
    • (should use same component as information page)
  • New page - Departments information (/admin/departments/:id:)

    • Header (background, H1 & breadcrumb)
    • H2 and content styling
    • Only one tab for now
    • Inline form for displaying information and editing
  • Edit department page (/admin/departments/:id:/edit)

    • (should use same component as Create department page)
  • Mobile view for all pages

  • Design Review by @Jerryescandon

Blockers

Blocked by

  1. feature
    vd1992
@Jerryescandon Jerryescandon added feature New feature or request. blocked: design Blocked by missing designs. labels Sep 9, 2024
@Jerryescandon Jerryescandon added this to the Admin migration milestone Sep 9, 2024
@gobyrne gobyrne added review in refinement Ready to be looked at and pulled into "ready to dev" and removed blocked: design Blocked by missing designs. labels Sep 12, 2024
@gobyrne
Copy link
Member

gobyrne commented Sep 12, 2024

Alright, I don't like that I'm doing this again, but here we are @NienkeBr

@gobyrne gobyrne changed the title ✨ New nav - Departments ✨ No new nav - Departments Sep 12, 2024
@gobyrne gobyrne changed the title ✨ No new nav - Departments ✨ Admin / Departments / mostly Styling update Sep 19, 2024
@vd1992 vd1992 removed the review in refinement Ready to be looked at and pulled into "ready to dev" label Sep 23, 2024
@gobyrne gobyrne added blocked: design Blocked by missing designs. review in refinement Ready to be looked at and pulled into "ready to dev" and removed blocked: design Blocked by missing designs. review in refinement Ready to be looked at and pulled into "ready to dev" labels Sep 26, 2024
Copy link

github-actions bot commented Oct 3, 2024

Status: Ready to merge ✔️

Issues blocking this PR:


This comment was automatically written by the Blocking Issues bot, and this PR will be monitored for further progress.

@github-actions github-actions bot added the blocked: dependencies Blocked by other issues. label Oct 3, 2024
@github-actions github-actions bot removed the blocked: dependencies Blocked by other issues. label Oct 18, 2024
@petertgiles petertgiles self-assigned this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request.
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

5 participants