-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Debt] Bump mock auth for rotating refresh tokens #10565
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10565 +/- ##
============================================
- Coverage 38.57% 38.55% -0.02%
Complexity 1426 1426
============================================
Files 999 999
Lines 30636 30636
Branches 6551 6554 +3
============================================
- Hits 11819 11813 -6
- Misses 18795 18800 +5
- Partials 22 23 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
The playwright test 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Eric 👍 tokens are working as expected
(Sorry missed this yesterday)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good. I can't get "Can submit application" in applicant/application.spec.ts to pass locally but it does in CI, so 🤷 .
The age old problem 😛 |
🤖 Resolves #9538
👋 Introduction
Bumps the mock auth container to set the rotating refresh tokens.
🧪 Testing
make down
thenmake up