Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debt] Bump mock auth for rotating refresh tokens #10565

Merged
merged 7 commits into from
Dec 5, 2024

Conversation

esizer
Copy link
Member

@esizer esizer commented May 31, 2024

🤖 Resolves #9538

👋 Introduction

Bumps the mock auth container to set the rotating refresh tokens.

🧪 Testing

  1. Rebuild docker container make down then make up
  2. Confirm mock auth functions
  3. Confirm refresh tokens work still

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.55%. Comparing base (ece7609) to head (aabbf17).

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10565      +/-   ##
============================================
- Coverage     38.57%   38.55%   -0.02%     
  Complexity     1426     1426              
============================================
  Files           999      999              
  Lines         30636    30636              
  Branches       6551     6554       +3     
============================================
- Hits          11819    11813       -6     
- Misses        18795    18800       +5     
- Partials         22       23       +1     
Flag Coverage Δ
integrationtests 71.09% <ø> (-0.11%) ⬇️
unittests 31.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yonikid15 yonikid15 self-requested a review June 6, 2024 13:33
Copy link
Contributor

@yonikid15 yonikid15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
The playwright test 😢

@yonikid15 yonikid15 self-requested a review June 6, 2024 14:34
@esizer esizer marked this pull request as draft June 6, 2024 14:44
@esizer esizer closed this Jun 6, 2024
@esizer esizer deleted the 9538-bump-mock-auth-rotate-refresh branch June 6, 2024 14:46
@esizer esizer restored the 9538-bump-mock-auth-rotate-refresh branch December 3, 2024 20:50
@esizer esizer reopened this Dec 3, 2024
@esizer esizer marked this pull request as ready for review December 3, 2024 21:37
Copy link
Contributor

@yonikid15 yonikid15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Eric 👍 tokens are working as expected
(Sorry missed this yesterday)

Copy link
Contributor

@petertgiles petertgiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. I can't get "Can submit application" in applicant/application.spec.ts to pass locally but it does in CI, so 🤷 .

@esizer
Copy link
Member Author

esizer commented Dec 5, 2024

I can't get "Can submit application" in applicant/application.spec.ts to pass locally but it does in CI, so 🤷 .

The age old problem 😛

@esizer esizer added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit 1d0fd96 Dec 5, 2024
10 of 11 checks passed
@esizer esizer deleted the 9538-bump-mock-auth-rotate-refresh branch December 5, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

♻️ Bump Mock Auth to set refresh token rotation
4 participants