Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Stabilize snapshots #10774

Merged
merged 2 commits into from
Jun 25, 2024
Merged

[Fix] Stabilize snapshots #10774

merged 2 commits into from
Jun 25, 2024

Conversation

esizer
Copy link
Member

@esizer esizer commented Jun 24, 2024

πŸ€– Resolves #10769

πŸ‘‹ Introduction

Stabilizes the footer snapshots.

πŸ•΅οΈ Details

We had some dynamic variables leading for false positives on chromatic diffs. This hardcodes those to make the snapshots more stable.

πŸ§ͺ Testing

Assist reviewers with steps they can take to test that the PR does what it says it does.

  1. Run storybook pnpm run storybook
  2. Confirm footer store contains the hard coded data

πŸ“Έ Screenshot

screenshot_24-Jun-2024_15-55-1719258929

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 38.28%. Comparing base (90ebd59) to head (3df2dd4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10774      +/-   ##
============================================
+ Coverage     38.04%   38.28%   +0.23%     
  Complexity     1649     1649              
============================================
  Files          1022     1021       -1     
  Lines         31356    31162     -194     
  Branches       6641     6508     -133     
============================================
  Hits          11930    11930              
+ Misses        19400    19197     -203     
- Partials         26       35       +9     
Flag Coverage Ξ”
integrationtests 67.89% <ΓΈ> (ΓΈ)
unittests 31.15% <ΓΈ> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Contributor

@mnigh mnigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component in Chromatic shows the change but the Chromatic snapshot doesn't seem to change πŸ˜•

@esizer
Copy link
Member Author

esizer commented Jun 24, 2024

The component in Chromatic shows the change but the Chromatic snapshot doesn't seem to change πŸ˜•

Turbosnap bit us with that one πŸ˜† It only creates new snapshots for story file diffs in git. Should see the proper snapshot now after format code to force snapshot change

@esizer esizer requested a review from mnigh June 25, 2024 12:18
Copy link
Contributor

@mnigh mnigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@esizer esizer added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit f08585e Jun 25, 2024
11 checks passed
@esizer esizer deleted the stabilize-stories branch June 25, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

♻️ Unstable Footer component stories in Chromatic
3 participants