Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Updates table nullMessage descriptions #10789

Merged
merged 6 commits into from
Jun 26, 2024
Merged

Conversation

mnigh
Copy link
Contributor

@mnigh mnigh commented Jun 25, 2024

🤖 Resolves #9463.

👋 Introduction

This PR removes the fallback for the nullMessage.description prop for the Table component and adds custom messages for where there is an add prop.

🧪 Testing

Assist reviewers with steps they can take to test that the PR does what it says it does.

  1. Navigate to tables
  2. Verify any table that has an add or create button has an instructional description when the table yields no results.

📸 Screenshots

add prop exists

Screen Shot 2024-06-25 at 15 38 47

add prop does not exist

Screen Shot 2024-06-25 at 15 43 33

@mnigh mnigh changed the title [Fix] Update table nullMessage descriptions [Fix] Updates table nullMessage descriptions Jun 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 38.27%. Comparing base (3949429) to head (c28f6b7).
Report is 2 commits behind head on main.

Files Patch % Lines
...c/components/Table/ResponsiveTable/NullMessage.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10789      +/-   ##
============================================
- Coverage     38.27%   38.27%   -0.01%     
  Complexity     1652     1652              
============================================
  Files          1021     1021              
  Lines         31192    31191       -1     
  Branches       6511     6509       -2     
============================================
- Hits          11939    11937       -2     
- Misses        19087    19229     +142     
+ Partials        166       25     -141     
Flag Coverage Δ
integrationtests 67.79% <ø> (-0.10%) ⬇️
unittests 31.16% <33.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@petertgiles petertgiles self-requested a review June 26, 2024 12:29
Copy link
Contributor

@petertgiles petertgiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, very clean. 🧹

@mnigh mnigh added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit e8932d1 Jun 26, 2024
13 checks passed
@mnigh mnigh deleted the 9463-table-null-messages branch June 26, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Null state message on pool candidates table doesn't make sense
3 participants