Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Remove floating promises #11665

Merged
merged 2 commits into from
Oct 2, 2024
Merged

[Fix] Remove floating promises #11665

merged 2 commits into from
Oct 2, 2024

Conversation

esizer
Copy link
Member

@esizer esizer commented Sep 27, 2024

🤖 Resolves #11381

👋 Introduction

Enables eslint rule and fixes associated errors.

🧪 Testing

  1. Confirm no lint errors
  2. Test promises to confirm functionality is unchanged

@vd1992 vd1992 self-requested a review October 1, 2024 19:58
vd1992
vd1992 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@vd1992 vd1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working through some of the touched pages and things seem to work unchanged. Good to go I think!

@esizer esizer added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit 7b143f7 Oct 2, 2024
12 checks passed
@esizer esizer deleted the 11381-fix-floating-promises branch October 2, 2024 12:19
@brindasasi brindasasi mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vd1992 vd1992 vd1992 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

♻️ No floating promises
2 participants
@esizer @vd1992