[Fix] Roll back lint coalescing bugs #11757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should be getting this into the release if we want to try the re-deploy v2.33.1 tonight or tmo. |
tristan-orourke
approved these changes
Oct 16, 2024
brindasasi
pushed a commit
that referenced
this pull request
Oct 16, 2024
* Fix lint coalescing bugs * type to boolean * type coercion to boolean (cherry picked from commit 1d9e2f0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Related to PR #11651
👋 Introduction
After finding a few bugs from #11651:
I took another look at that PR and identified a few more. These are all places where boolean OR comparisons were improperly changed to null coalesces.
🕵️ Details
🧪 Testing