Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Notifications panel flashes double state #11758

Merged
merged 6 commits into from
Nov 1, 2024

Conversation

yonikid15
Copy link
Contributor

🤖 Resolves #11604

👋 Introduction

  • Pauses the live notification query till max pages query is finished. This should prevent the user from seeing any double notification list state.

🧪 Testing

  1. Create a notification. The quickest way (i think) is to login as admin and create an application. Then on the edit user page, change the status.
    image
  2. Open up the notifications panel, and ensure no double flash occurs.

Copy link
Member

@tristan-orourke tristan-orourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I'm still seeing it consistently in the following case:

  1. Log in as admin, go to a candidates table
  2. select multiple candidates
  3. click download as CSV
  4. immediately open notification pane
  5. See doubled state as new notification appears

I tried to take a video, but recordit keeps crashing...

@tristan-orourke tristan-orourke removed their request for review October 31, 2024 18:01
Copy link
Contributor

@JamesHuf JamesHuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 👍

@yonikid15 yonikid15 dismissed tristan-orourke’s stale review November 1, 2024 15:04

Passed on to another developer

@yonikid15 yonikid15 added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit daa8785 Nov 1, 2024
10 of 11 checks passed
@yonikid15 yonikid15 deleted the 11604-fix-notification-panel-flash-double-state branch November 1, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Notification panel flashes doubled state
3 participants