[Feature] Send 'new pool' emails overnight #11804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brindasasi
reviewed
Oct 31, 2024
brindasasi
reviewed
Oct 31, 2024
| $startOfSpan = Carbon::now()->subHours(24); // assuming the last reporting job ran about 24 hours ago | ||
| $this->info("Finding pools published between $startOfSpan and $endOfSpan."); | ||
|
|
||
| $poolsPublishedRecently = Pool::query() |
There was a problem hiding this comment.
one more question .. this pr checks the pools published within 24 hours but doesn't check for open pools.
In the use case , they have published something accidentally and they closed it immediately, we would still send notification for that closed pool.
I'm wondering should we add that check for only active pools?
There was a problem hiding this comment.
Good catch. If I had remembered to update the tests first, this would have been caught. 🤦
brindasasi
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Resolves #11709
👋 Introduction
Sends "new pool published" emails overnight instead of immediately.
🕵️ Details
One of the AC is:
This is no longer relevant since the script is running from the cron job and not a task scheduler worker. It no longer has a time limit - I think. 😅
🧪 Testing
./artisan send-notifications:pool-publishedAlso: