Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Training fund page #11821

Merged
merged 19 commits into from
Oct 28, 2024
Merged

[FEATURE] Training fund page #11821

merged 19 commits into from
Oct 28, 2024

Conversation

petertgiles
Copy link
Contributor

@petertgiles petertgiles commented Oct 23, 2024 •
edited
Loading

🤖 Resolves #11794, #11799

👋 Introduction

Adds the new IT training fund page.

🕵️ Details

I noticed our heading component doesn't wrap how it should in designs, especially in mobile widths. I can open an issue for that.

🧪 Testing

  1. Rebuild the site
  2. Navigate to /en/it-training-fund
  • Content correct
    • en
    • fr
  • Matches design
    • desktop
    • mobile
  • Card on homepage

📸 Screenshot

image

@petertgiles petertgiles linked an issue Oct 23, 2024 that may be closed by this pull request
✨ New card on homepage for IT training fund #11799
Closed
4 tasks
@yonikid15 yonikid15 self-requested a review October 25, 2024 14:07
yonikid15
yonikid15 requested changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@yonikid15 yonikid15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amaze-za-ing ⭐, just a few small tweaks left.

apps/web/src/pages/ItTrainingFundPage/ItTrainingFundPage.tsx Outdated Show resolved Hide resolved
apps/web/src/pages/ItTrainingFundPage/ItTrainingFundPage.tsx Show resolved Hide resolved
apps/web/src/pages/ItTrainingFundPage/ItTrainingFundPage.tsx Show resolved Hide resolved
apps/web/src/pages/ItTrainingFundPage/ItTrainingFundPage.tsx Show resolved Hide resolved
apps/web/src/pages/ItTrainingFundPage/ItTrainingFundPage.tsx Show resolved Hide resolved
apps/web/src/pages/ItTrainingFundPage/ItTrainingFundPage.tsx Outdated Show resolved Hide resolved
apps/web/src/pages/ItTrainingFundPage/ItTrainingFundPage.tsx Outdated Show resolved Hide resolved
apps/web/src/pages/ItTrainingFundPage/ItTrainingFundPage.tsx Outdated Show resolved Hide resolved
apps/web/src/pages/ItTrainingFundPage/ItTrainingFundPage.tsx Outdated Show resolved Hide resolved
yonikid15
yonikid15 requested changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@yonikid15 yonikid15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man we almost forgot adding the SEO component 😆

      <SEO
        title={intl.formatMessage(pageTitle)}
        description={intl.formatMessage(pageSubtitle)}
      />

Screenshot from 2024-10-25 15-18-44

@petertgiles
Copy link
Contributor Author

Oh wow, good catch!
add seo component

Guess I'll post a bug issue for the directive page, too. 😬

yonikid15
yonikid15 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@yonikid15 yonikid15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@petertgiles petertgiles added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit e9f6a71 Oct 28, 2024
11 checks passed
@petertgiles petertgiles deleted the 11794-training-fund-page branch October 28, 2024 12:23
brindasasi pushed a commit that referenced this pull request Oct 28, 2024
@petertgiles @brindasasi
[FEATURE] Training fund page (#11821)
3ce1fbd 
* page skeleton

* first two sections

* set up cards

* desktop version

* homepage link

* resized images

* text decoration

* English copy updates

* sign up link

* translations and EN fixes

* merge translations

* ragged cards

* switch to old hero

* update survey links

* localize navigar link

* remove strong tags

* FR edits

* semantic heading for cards

* add seo component

(cherry picked from commit e9f6a71)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yonikid15 yonikid15 yonikid15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ New card on homepage for IT training fund ✨ New IT Training Fund static page
2 participants
@petertgiles @yonikid15