Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Allow community admins to view community access tab #11871

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

JamesHuf
Copy link
Contributor

πŸ€– Resolves #11822

πŸ‘‹ Introduction

Fix to allow community admins to view the manage access tab for communities.

πŸ•΅οΈ Details

This appears to have been a result of #11811 removing teamable from roleAssignments in UserAuthInfo. I resolved this by querying for the users roleAssignments with teamable on the page.

πŸ§ͺ Testing

  1. Sign in as a community admin (ex. community@test.com)
  2. Navigate to the view page for a community en/admin/communities/{communityId}
  3. Confirm you can view and navigate to the "manage access" tab
  4. Confirm you can add community recruiters (but not community admins) to the community

πŸ“Έ Screenshot

image

@yonikid15 yonikid15 self-requested a review October 31, 2024 14:18
Copy link
Contributor

@yonikid15 yonikid15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ‘

@JamesHuf JamesHuf added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit 57a27fd Oct 31, 2024
12 checks passed
@JamesHuf JamesHuf deleted the 11822-community-manager-access-tab branch October 31, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

πŸ› Community Admin can't see the manage access tab
2 participants