Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Copy] Updates error message when a file no longer exists #11874

Merged
merged 2 commits into from
Oct 30, 2024
Merged

[Copy] Updates error message when a file no longer exists #11874

merged 2 commits into from
Oct 30, 2024

Conversation

mnigh
Copy link
Contributor

@mnigh mnigh commented Oct 29, 2024 •
edited
Loading

🤖 Resolves #11098.

👋 Introduction

This PR updates the error message when a file no longer exists.

📸 Screenshots

English

Screen Shot 2024-10-29 at 12 05 06

French

Screen Shot 2024-10-29 at 14 23 26

🧪 Testing

  1. Generate a file (e.g. profile document)
  2. Manually delete the generated file in the backend
  3. Click the notification
  4. Verify message uses updated copy

@mnigh mnigh added the blocked: copy Blocked by missing copy or translations label Oct 29, 2024
@mnigh mnigh removed the blocked: copy Blocked by missing copy or translations label Oct 29, 2024
@petertgiles petertgiles self-requested a review October 30, 2024 14:34
petertgiles
petertgiles approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@petertgiles petertgiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for grabbing that one.

@mnigh mnigh added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 309793f Oct 30, 2024
12 checks passed
@mnigh mnigh deleted the 11098-copy-file-download branch October 30, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertgiles petertgiles petertgiles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 File download error is sometimes wrong
2 participants
@mnigh @petertgiles