Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update admin skill pages styling #11877

Merged
merged 18 commits into from
Nov 1, 2024
Merged

Conversation

petertgiles
Copy link
Contributor

@petertgiles petertgiles commented Oct 30, 2024

πŸ€– Resolves #11476

πŸ‘‹ Introduction

Updates the styling of the admin skill pages and adds a new view skill page.

πŸ•΅οΈ Details

I've imported the changes to the Hero and the CardSectioned component from #11853 to this PR as well.

I've spun off the rich text editor for descriptions:
#11878

πŸ§ͺ Testing

  • Rebuild and log in as admin
  • View the department pages
    • Mobile
    • Desktop

πŸ“Έ Screenshot

image

@yonikid15 yonikid15 self-requested a review October 31, 2024 18:42
Copy link
Contributor

@yonikid15 yonikid15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good πŸ‘ Just one null message missing

apps/web/src/pages/Skills/ViewSkillPage.tsx Outdated Show resolved Hide resolved
@petertgiles petertgiles added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit ba03994 Nov 1, 2024
10 of 11 checks passed
@petertgiles petertgiles deleted the 11476-skills-editor branch November 1, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Admin / Skills editor / mostly Styling update
2 participants