Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overlap on main nav and hero #11898

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Fix overlap on main nav and hero #11898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/web/src/components/Hero/Hero.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,6 @@ const Hero = (props: HeroWithNavTabsProps | HeroWithOverlapProps) => {
data-h2-wrapper="base(center, large, x1) p-tablet(center, large, x2)"
data-h2-position="base(relative)"
data-h2-margin="base(-x5, auto, 0, auto)"
data-h2-z-index="base(4)"
>
{children}
</div>
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/src/components/NavMenu/NavMenuWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
import { NavMenuProvider } from "./NavMenuProvider";
import NavMenu from "./NavMenu";

export interface NavMenuProps {

Check warning on line 18 in packages/ui/src/components/NavMenu/NavMenuWrapper.tsx

View workflow job for this annotation

GitHub Actions / Lint 

exported declaration 'NavMenuProps' not used within other modules
/** Sets the section to be 'open' by default */
defaultOpen?: boolean;
/** Controllable open state */
Expand Down Expand Up @@ -93,7 +93,7 @@
transition={{ duration: 0.2, ease: "easeInOut" }}
data-h2-flex-item="base(content)"
data-h2-position="base(fixed) l-tablet(sticky)"
data-h2-top="l-tablet(0)"
data-h2-top="l-tablet(-1px)"
data-h2-bottom="base(x3.5) l-tablet(auto)"
data-h2-right="base(x.75) l-tablet(auto)"
data-h2-left="base(x.75) l-tablet(auto)"
Expand Down
Loading