Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Generated docs add work experience fields #12108

Merged
merged 11 commits into from
Dec 3, 2024
Merged

[Feature] Generated docs add work experience fields #12108

merged 11 commits into from
Dec 3, 2024

Conversation

vd1992
Copy link
Contributor

@vd1992 vd1992 commented Nov 27, 2024 •
edited
Loading

🤖 Resolves #11869

👋 Introduction

Update the profile download per link

🕵️ Details

Whole lot of conditionals but I think rendering this effectively markup is going to look like that

🧪 Testing

  1. Download various user profile docs
  2. Scroll to work experiences and observe
  3. Compare to example linked above

📸 Screenshot

image

image

image

image

@vd1992 vd1992 marked this pull request as ready for review November 28, 2024 20:11
@vd1992
Copy link
Contributor Author

vd1992 commented Dec 2, 2024

Now in French too! 811691d

@petertgiles petertgiles self-requested a review December 3, 2024 13:37
petertgiles
petertgiles requested changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@petertgiles petertgiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Two small suggestions.

api/app/Models/WorkExperience.php Show resolved Hide resolved
api/app/Traits/Generator/GeneratesUserDoc.php Outdated Show resolved Hide resolved
@vd1992 vd1992 requested a review from petertgiles December 3, 2024 17:56
@vd1992 vd1992 added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit 4665f8d Dec 3, 2024
7 checks passed
@vd1992 vd1992 deleted the 11869-add-work-experience-fields-doc branch December 3, 2024 20:50
@brindasasi brindasasi mentioned this pull request Dec 11, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertgiles petertgiles petertgiles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ Generated files - New work experience fields
2 participants
@vd1992 @petertgiles