Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Copy] Updates French translation of skill family #12143

Merged
merged 20 commits into from
Dec 2, 2024
Merged

[Copy] Updates French translation of skill family #12143

merged 20 commits into from
Dec 2, 2024

Conversation

mnigh
Copy link
Contributor

@mnigh mnigh commented Nov 28, 2024 •
edited
Loading

🤖 Resolves #12017.

👋 Introduction

This PR updates the French translation of skill family. It also updates a few instances of title case to sentence case, and consolidates a string (Description).

🧪 Testing

Verify famille not in codebase when related to skill family.

📸 Screenshots

English Screen Shot 2024-11-28 at 12 59 41
French Screen Shot 2024-11-28 at 13 04 52 Screen Shot 2024-11-28 at 13 05 26 Screen Shot 2024-11-28 at 13 06 20 Screen Shot 2024-11-28 at 13 07 22 Screen Shot 2024-11-28 at 13 08 16 Screen Shot 2024-11-28 at 13 08 48 Screen Shot 2024-11-28 at 13 09 28 Screen Shot 2024-11-28 at 13 08 59 Screen Shot 2024-11-28 at 13 11 46 Screen Shot 2024-11-28 at 13 12 13 Screen Shot 2024-11-28 at 13 00 59 Screen Shot 2024-11-28 at 13 01 10 Screen Shot 2024-11-28 at 13 03 49

mnigh added 13 commits November 28, 2024 10:44
@mnigh
Update Skill family to sentence case
e9e236f
@mnigh
Consolidate string for Description
43f3036
@mnigh
Replace Famille de compétences with Groupe de compétences
af79cf0
@mnigh
Replace Familles de compétences with Groupes de compétences
d9b4d49
@mnigh
Replace une famille de compétences with un groupe de compétences
f9caef0
@mnigh
Replace de la famille de compétences with du groupe de compétences
f7e7765
@mnigh
Replace la famille de compétences with le groupe de compétences
f642880
@mnigh
Replace famille de compétences with groupe de compétences
021cb0c
@mnigh
Replace Compétences de cette famille with Compétences de ce groupe
68ecb86
@mnigh
Replace Annulez et revenez aux familles de compétences with Annulez e…
5bc7fdf 
…t revenez aux groupes de compétences
@mnigh
Replace Sélectionnez une famille ou plus with Sélectionnez un groupe …
765d58b 
…ou plus
@mnigh
Update Skill family to sentence case
01d9028
@mnigh
Replace toute famille de compétences with n'importe quel groupe de co…
ad3ee42 
…mpétences
@mnigh mnigh marked this pull request as ready for review November 28, 2024 18:17
@mnigh mnigh requested a review from NienkeBr November 28, 2024 18:17
esizer
esizer approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@esizer esizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

@NienkeBr
Copy link
Contributor

NienkeBr commented Nov 29, 2024 •
edited
Loading

  1. could you also use lower case for skill?
    image
  2. Could you make the button here say "Créez le groupe de compétences"?
    image
  3. Could you please make this say "Groupe de compétences mis à jour avec succès!"
    image

NienkeBr
NienkeBr reviewed Nov 29, 2024
View reviewed changes
apps/web/src/lang/fr.json Outdated Show resolved Hide resolved
@mnigh
Copy link
Contributor Author

mnigh commented Nov 29, 2024

  1. could you also use lower case for skill?

i can't believe i missed that: thanks for catching!

Screenshot

Screen Shot 2024-11-29 at 15 26 57
  1. Could you make the button here say "Créez le groupe de compétences"?

Screenshot

Screen Shot 2024-11-29 at 15 27 35
  1. Could you please make this say "Groupe de compétences mis à jour avec succès!"

Screenshot

Screen Shot 2024-11-29 at 15 28 34

@mnigh mnigh added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit b2d992b Dec 2, 2024
12 checks passed
@mnigh mnigh deleted the 12017-copy-skill-family branch December 2, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NienkeBr NienkeBr NienkeBr left review comments

@esizer esizer esizer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🔤 Update French translation of skill family
3 participants
@mnigh @NienkeBr @esizer