Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debt] Removes ongoing jobs/recruitment #12179

Merged
merged 7 commits into from
Dec 5, 2024
Merged

[Debt] Removes ongoing jobs/recruitment #12179

merged 7 commits into from
Dec 5, 2024

Conversation

mnigh
Copy link
Contributor

@mnigh mnigh commented Dec 3, 2024

🤖 Resolves #12151.

👋 Introduction

This PR removes the ongoing jobs UI and updates copy to remove references to ongoing jobs/recruitment. It also removes IT jobs (ongoing) (IT_JOBS_ONGOING) from the list of publishing groups. Finally, it provides code to run in Laravel Tinker to update pools with a publishing group of IT_JOBS_ONGOING to have a publishing group of IT_JOBS.

🧪 Testing

  1. make artisan CMD="tinker"
# 1. get all pools that have a publishing group of it jobs ongoing
$pools = Pool::where('publishing_group', PublishingGroup::IT_JOBS_ONGOING);
# 2. get count of pools that have a publishing group of it jobs ongoing
$pools->count();
# 3. update pools that have a publishing group of it jobs ongoing to it jobs
$pools->update(array('publishing_group' => PublishingGroup::IT_JOBS));
# 4. get count of pools that have a publishing group of it jobs ongoing
Pool::where('publishing_group', PublishingGroup::IT_JOBS_ONGOING)->count();
  1. Verify no pools have publishing_group value of IT_JOBS_ONGOING
  2. make refresh-api
  3. make seed-fresh
  4. pnpm i; pnpm build:fresh
  5. Navigate to http://localhost:8000/en/browse/pools
  6. Verify no errors
  7. Navigate to http://localhost:8000/en/search
  8. Verify no errors

🚚 Deployment

Important

This should be done before the code itself is deployed.

Update all pools that have a publishing group of IT_JOBS_ONGOING to IT_JOBS in DEV, UAT, PROD verticals in Azure.

php artisan tinker

# 1. get all pools that have a publishing group of it jobs ongoing
$pools = Pool::where('publishing_group', PublishingGroup::IT_JOBS_ONGOING);
# 2. get count of pools that have a publishing group of it jobs ongoing
$pools->count();
# 3. update pools that have a publishing group of it jobs ongoing to it jobs
$pools->update(array('publishing_group' => PublishingGroup::IT_JOBS));
# 4. get count of pools that have a publishing group of it jobs ongoing
Pool::where('publishing_group', PublishingGroup::IT_JOBS_ONGOING)->count();

@mnigh mnigh marked this pull request as ready for review December 4, 2024 22:24
Copy link
Member

@esizer esizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🪓

@tristan-orourke tristan-orourke added the deployment Requires a change during deployment label Dec 5, 2024
@tristan-orourke
Copy link
Member

Okay, after discussing in standup, we'll run the tinker commands before the next deployment, and not create an artisan script this time.

@mnigh mnigh added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit e839df6 Dec 5, 2024
13 checks passed
@mnigh mnigh deleted the 12151-ongoing-jobs branch December 5, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Requires a change during deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

♻️ Remove Ongoing Jobs publishing group and associated UI
3 participants