[Fix] Sort nulls last for pool publish date

[petertgiles]

🤖 Resolves #11535

👋 Introduction

Sorts publish date with nulls last on the pool table.

🕵️ Details

I just added a new sorting scope to the pool paginated query. It would be nice to generalize this to something we could use throughout the schema but for now it's a stopgap.

The new scope could be used for any physical column in the table but is not advanced enough to handle relationships like Lighthouse's directive can. It also only accepts a single column at a time.

🧪 Testing

Frontend

1. Rebuild and log in as admin@test.com
2. Navigate to /en/admin/pools
3. Play with sorting options

• initial sort is still created date
• bookmarks is still the overriding sort option
• sorting by publishing date, ascending and descending, sorts nulls to the end
• other sorting options unaffected

Backend

1. Navigate to /admin/graphiql and add an authorization header with a bearer token for admin@test.com
2. Play with sorting options

query Pools($where:PoolFilterInput, $orderByColumn: OrderByColumnInput) {
  poolsPaginated(first: 100, orderByColumn: $orderByColumn, where:$where) {
    data {
      id      
      publishedAt
    }    
  }
}
-----
{
  "where": {
    "statuses": [
      "DRAFT",
      "PUBLISHED"
    ]
  },
  "orderByColumn": {
    "column": "published_at",
    "order": "DESC",
    "nulls": "ORDER_LAST"
  }
}

• scope only accepts real column names
• scope only accepts real options for "order" and "nulls"
• scope handles undefined "nulls" option
• scope sorts as expected

📸 Screenshot

🚚 Deployment

[vd1992]

Looks and functions well, aside from linting my only thing to note it we should probably have that bespoke sort covered under some sort of PHP test.

[petertgiles]

we should probably have that bespoke sort covered under some sort of PHP test

Good call!
Added in test suite.

[vd1992]

Fantastic! Thanks for adding testing