Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Debt] Moves admin routes as children of root route #12221

Merged
merged 5 commits into from
Dec 9, 2024
Merged

[Debt] Moves admin routes as children of root route #12221

merged 5 commits into from
Dec 9, 2024

Conversation

mnigh
Copy link
Contributor

@mnigh mnigh commented Dec 6, 2024

🤖 Resolves #12032.

👋 Introduction

This PR moves admin routes as children of root route. It removes the unused AdminLayout component and story.

🧪 Testing

  1. Navigate to admin route
  2. Ensure error boundary still renders
  3. Navigate to non-admin route
  4. Ensure error boundary still renders

@mnigh mnigh marked this pull request as ready for review December 6, 2024 22:29
petertgiles
petertgiles approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@petertgiles petertgiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. Nice!

@mnigh mnigh added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit 46e23e3 Dec 9, 2024
11 checks passed
@mnigh mnigh deleted the 12032-admin-layout branch December 9, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertgiles petertgiles petertgiles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

♻️ Move admin routes as children of root route
2 participants
@mnigh @petertgiles