Skip to content
This repository has been archived by the owner on Mar 16, 2021. It is now read-only.

Add DialogFragment #42

Merged
merged 3 commits into from
Dec 13, 2016
Merged

Add DialogFragment #42

merged 3 commits into from
Dec 13, 2016

Conversation

StefMa
Copy link
Contributor

@StefMa StefMa commented Dec 13, 2016

This is the same as #20 but with the fixed AppCompatDialogFragment.

As @passsy said

As a first step I'm ok with the duplicated code.

When it's merged I'll care of an delegate...

I've also tested it.
Before (Without AppCompat):
notappcompat
After (With AppCompat):
appcompat

@StefMa StefMa mentioned this pull request Dec 13, 2016
@StefMa StefMa requested a review from passsy December 13, 2016 15:40
@passsy passsy merged commit d816bc6 into GCX-HCI:master Dec 13, 2016
@StefMa StefMa mentioned this pull request Dec 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

3 participants